Arbitrary chart variable assignment by @gotkaren's PR714 #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catherinedevlin
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
=======================================
Coverage 81.69% 81.69%
=======================================
Files 18 18
Lines 1393 1393
Branches 271 271
=======================================
Hits 1138 1138
Misses 209 209
Partials 46 46 ☔ View full report in Codecov by Sentry. |
rht
reviewed
Apr 27, 2023
| backgroundColor: convertColorOpacity(s.Color), | ||
| data: [], | ||
| }; | ||
| for (var property in s){ |
There was a problem hiding this comment.
Should be const instead of var.
rht
reviewed
Apr 27, 2023
| for (var property in s){ | ||
| new_series[property] = s[property]; | ||
| } | ||
| new_series["backgroundColor"] = convertColorOpacity(s.Color) |
There was a problem hiding this comment.
This has already been specified in L31.
|
@catherinedevlin I tried to edit your branch to apply my comments, but it appears that I am not able to push to the main branch of a fork. I will reopen your PR in a new PR instead. |
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
|
Superseded by #1685. |
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
Original work: projectmesa#714 and projectmesa#1673. Co-Authored-By: Catherine Devlin <devlinch@corning.com>
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
Original work: projectmesa#714 and projectmesa#1673. Co-Authored-By: Catherine Devlin <devlinch@corning.com>
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
Original work: projectmesa#714 and projectmesa#1673. Co-Authored-By: Catherine Devlin <devlinch@corning.com>
rht
added a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
Original work: projectmesa#714 and projectmesa#1673. Co-authored-by: Karen Gonzalez <karenyglez.tr@gmail.com> Co-authored-by: rht <rhtbot@protonmail.com>
rht
added a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports passing arbitrary chart variables to the Chart Module.
Supersedes #714 by @gotkaren. I apologize that I wasn't able to preserve any of her commits, but there have been too many changes since then and I wasn't able to unsnarl git.
I don't know if we have a way to test JavaScript, but I informally tried some examples mesa-examples; they didn't break, and I was able to change chart visual parameters. For instance, changed https://github.com/projectmesa/mesa-examples/blob/68c8e87c8e9b0eed5cf87419bcec4de5839ff5a1/examples/forest_fire/forest_fire/server.py#L23 to
[{"Label": label, "Color": color, "borderWidth": 10, "pointRadius": 10} for (label, color) in COLORS.items()]and got the desired effect.
I didn't make any changes to the docs - as far as I can see, they already imply that you ought to be able to submit arbitrary parameters to a chart, so this PR just brings the code into sync with the docs.