Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label sync, update labels, add new decision issue type #3795

Merged
merged 1 commit into from
Jun 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/ISSUE_TEMPLATE/decision.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: Decision
about: A binding record of a decision
title: ''
labels: kind/decision, lifecycle/needs-triage
assignees: ''

---
<!-- Thanks for asking for a decision! Here are some tips for you:

1. Decisions should be large ones, that cut across many parts of a repo
or the project as a whole. "Should we change Contour's support policy"
is an example of a decision that's relevant here, "Should we implement
this feature" is an example of a decision that's not.
If in doubt, ask in #contour on the Kubernetes Slack.
2. Contour's maintainers have the binding votes, but non-binding votes are welcomed.
-->

**What do you want the project to decide?**
<!-- A clear and concise description of what the decision is. -->


**Anything else you would like to add:**
<!-- Background or other information that will assist people in understanding why we need to decide this. -->
4 changes: 1 addition & 3 deletions hack/release/sync-repo-labels.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ readonly REPO=$(cd "${HERE}/../.." && pwd)
readonly TOKEN=${TOKEN:-}

readonly DOCKER=${DOCKER:-docker}
readonly LABELS=${LABELS:-${REPO}/site/_data/github-labels.yaml}
readonly LABELS=${LABELS:-${REPO}/site/data/github-labels.yaml}

set -o errexit
set -o nounset
Expand Down Expand Up @@ -55,5 +55,3 @@ labelsync \
--skip projectcontour/toc \
--config "${yaml}" \
--token "${token}"

# TODO(jpeach): add the -confirm flag to enable changes.
27 changes: 27 additions & 0 deletions site/data/github-labels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,20 @@ default:
name: area/operational
target: both
addedBy: label
- color: 0052cc
description: Issues or PRs about making Contour interoperate with service meshes. Contour is not a service mesh.
name: area/service-mesh
previously:
- name: "area/service mesh"
target: both
addedBy: label
- color: 0052cc
description: Issues or PRs about Contour's support for sticky sessions.
name: area/sticky-session
previously:
- name: "area/sticky session"
target: both
addedBy: label

# Blocked.
- color: "FF7B7B"
Expand Down Expand Up @@ -171,6 +185,11 @@ default:
addedBy: anyone
previously:
- name: bug
- color: 8cff82
description: Categorizes issue as a decision to be voted on.
name: kind/decision
target: issue
addedBy: anyone
- color: c7def8
description: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
name: kind/cleanup
Expand Down Expand Up @@ -249,6 +268,14 @@ default:
target: both
addedBy: anyone

# Documentation
- color: 9F629C
description: Indicates that an issue or PR needs attention from a technical writer or a docs update.
name: doc-impact
target: both
addedBy: anyone


# Priority.
- color: fef2c0
description: Lowest priority. Possibly useful, but not yet enough support to actually get it done. # These are mostly place-holders for potentially good ideas, so that they don't get completely forgotten, and can be referenced /deduped every time they come up.
Expand Down