Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label sync, update labels, add new decision issue type #3795

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

youngnick
Copy link
Member

I've fixed the permissions issues for the contour-perf repo, but there was also a bug from the site move (fixed as well).

Then I've updated the labels with some that had been manually created, and added the new "Decision" issue template.

Signed-off-by: Nick Young ynick@vmware.com

@youngnick youngnick requested a review from a team as a code owner June 10, 2021 01:51
@youngnick youngnick requested review from danehans and sunjayBhatia and removed request for a team June 10, 2021 01:51
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #3795 (c19a715) into main (caedf10) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3795   +/-   ##
=======================================
  Coverage   75.83%   75.83%           
=======================================
  Files         107      107           
  Lines        7338     7338           
=======================================
  Hits         5565     5565           
  Misses       1652     1652           
  Partials      121      121           

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one item to address

.github/ISSUE_TEMPLATE/decision.md Outdated Show resolved Hide resolved
Signed-off-by: Nick Young <ynick@vmware.com>
@youngnick youngnick force-pushed the labels-and-decisions branch from 09ddfb4 to c19a715 Compare June 15, 2021 00:31
@skriss skriss merged commit bfbe34f into projectcontour:main Jun 15, 2021
@skriss
Copy link
Member

skriss commented Jun 15, 2021

Looks like it ran successfully: https://github.com/projectcontour/contour/actions/runs/938870413

It took 25min but guessing there was some API throttling going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants