Support DEl on non-existent Azure endpoint #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When asked to release an IP for an AzureEndpoint which does not exist, simply return success.
This is modeled after how the Azure plugin handles this case: https://github.com/Azure/azure-container-networking/blob/master/cni/network/network.go#L609-L615
There is a case where the kubelet starts a pod before the CNI plugin can successfully network it. In this case, we'll get a DEL call for a container that does not have an IP assigned, and we need to return successfully.
It's expected CNI plugins will return successfully on DEL calls for things that do not exist.
Todos
Release Note