Calico support for azure-vnet-ipam #4154

caseydavenport · 2018-10-31T21:47:53Z

What this PR does / why we need it:

This PR does a few things:

Updates Calico to v3.3.0 (latest as of this moment)
Introduces support for using Calico network policy with Azure vnet networking.

Special notes for your reviewer:

There are a couple areas where I could use some acs-engine help. I'll call them out explicitly in comments on the areas in question.

If applicable:

documentation
unit tests
tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Support networkPolicy=calico with networkPlugin=azure

msftclas · 2018-10-31T21:48:05Z

All CLA requirements met.

caseydavenport · 2018-10-31T21:49:11Z

parts/k8s/kubernetesconfigs.sh

@@ -185,8 +185,10 @@ function configureCNI() {
    retrycmd_if_failure 30 6 10 modprobe br_netfilter || exit $ERR_MODPROBE_FAIL
    echo -n "br_netfilter" > /etc/modules-load.d/br_netfilter.conf
    if [[ "${NETWORK_PLUGIN}" = "azure" ]]; then
-        mv $CNI_BIN_DIR/10-azure.conflist $CNI_CONFIG_DIR/
-        chmod 600 $CNI_CONFIG_DIR/10-azure.conflist
+	# Casey TODO: When using Calico with Azure networking, we don't want this CNI


This is one area where I'm not sure what the best approach is - when using Calico for network policy with the Azure plugin, Calico will install its own config via the DaemonSet, so we don't want to install this one.

I don't see a NETWORK_POLICY environment variable set in this script, though I could be missing something?

@jackfrancis I'd appreciate any thoughts on how to handle this bit of code.

We need skip installation of this file when using NetworkPolicy=Calico with NetworkPlugin=Azure.

But right now, this always gets installed when NetworkPlugin=Azure. Is there recommended way for me to plumb the right information to this stage?

@caseydavenport NETWORK_POLICY could be added in kubernetesmastervars.t, e.g. ' NETWORK_POLICY=',parameters('networkPolicy')

parts/k8s/addons/kubernetesmasteraddons-calico-daemonset.yaml

caseydavenport · 2018-10-31T22:16:38Z

@jackfrancis would appreciate your thoughts on this one :)

jackfrancis · 2018-11-01T15:59:34Z

This is looking good @caseydavenport. Just to clarify that your intent matches the implementation: the template files under parts/k8s/addons/<version> will be rendered only for k8s major.minor versions (e.g., v1.10.n) that match <version>. I see you have included changes to the 1.10 version of the calico manifest. Given the current implementation, not including your changes to the < 1.10 versions and the 1.11 version means that the calico + Azure CNI implementation will only be delivered w/ k8s 1.10 or k8s 1.12+.

The backstory there is that the tolerations spec is slightly different for 1.12 and greater, other than that the manifests are identical.

So this is just a reminder that once we get a working manifest for one version of k8s, we'll want to copy/paste the changes across all the 1.11 through 1.7 templates (tedious work, I know). Lemme know if that doesn't make sense.

caseydavenport · 2018-11-02T23:51:07Z

@jackfrancis yep, I'm happy to copy to older (and newer) versions once we agree this change set makes sense! TBH, I did v1.10 because it seemed to be what was used by default and was easy to test my changes - suspected I'd need to port them elsewhere as well, though.

I've pushed a change which configures the CNI config based on the specified plugin and tested it works locally. The last bit is around not installing the Azure CNI config when Calico is enabled, still need to find a way to do that.

feiskyer

The change lgtm, and also verified with a new provisioned cluster (v1.10).

feiskyer · 2018-11-05T06:48:09Z

The following test is failing because of adding calico with azure plugin:

--- FAIL: Test_Properties_ValidateNetworkPluginPlusPolicy (0.00s)
    validate_test.go:704: should error on networkPolicy="calico" + networkPlugin="azure"

codecov · 2018-11-05T17:19:50Z

Codecov Report

Merging #4154 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4154      +/-   ##
==========================================
- Coverage   50.52%   50.49%   -0.03%     
==========================================
  Files         109      109              
  Lines       16999    16981      -18     
==========================================
- Hits         8589     8575      -14     
+ Misses       7611     7609       -2     
+ Partials      799      797       -2

jackfrancis · 2018-11-05T17:24:14Z

@caseydavenport, I made two changes to move testing forward:

now passing networkPolicy (i.e., calico) directly to the provision scripts so that they may conditionally do foo based on whether or not calico is present
fixed validation test

We're testing this continuously starting now, so far looks good!

jackfrancis · 2018-11-05T17:25:19Z

Also, rebased/force-pushed so you'll need to blow away your local branch and pull down what's in your fork origin. Hope that's not too annoying (and that you didn't have any local changes that will be hard to manually reconcile :| )

caseydavenport · 2018-11-05T19:29:31Z

@jackfrancis awesome, thanks for that!

This looks good to me - I'll get started porting the manifest changes to other versions.

caseydavenport · 2018-11-05T22:29:33Z

@jackfrancis I've updated the other addon manifests for the other k8s versions as well to match what I had done for 1.10.

What's the next step for this guy?

jackfrancis · 2018-11-06T00:41:08Z

parts/k8s/addons/1.10/kubernetesmasteraddons-calico-daemonset.yaml

@@ -395,7 +390,7 @@ spec:
        # This container installs the Calico CNI binaries
        # and CNI network config file on each node.
        - name: install-cni
-          image: quay.io/calico/cni:v3.1.3
+          image: quay.io/calico/cni:v3.4.0-0.dev-13-gcda66d6


Is there a final version for the cni image, say the equivalent of quay.io/calico/typha:v3.3.0?

jackfrancis · 2018-11-06T00:42:59Z

@caseydavenport this /lgtm for merge once we validate we have the install-cni image reference we want

feiskyer

LGTM as well

jackfrancis · 2018-11-06T16:38:07Z

@caseydavenport have you tested this change against a 1.12 cluster buildout? Initial test signal was non-passing, wil retry.

caseydavenport · 2018-11-06T17:23:57Z

@jackfrancis have only tested on v1.10 so far, but I can take a look today.

jackfrancis · 2018-11-06T17:24:31Z

Seems coredns is not coming online (our 1.12 implementation uses coredns)

caseydavenport · 2018-11-06T22:15:21Z

@jackfrancis ok, I got to the bottom of it.

For whatever reason 1.12 has a different timing and exposed a race in the new Azure code I wrote in the CNI plugin. I've got a patch working here: projectcalico/cni-plugin#634

Will update this PR to include it once merged.

jackfrancis · 2018-11-06T22:55:40Z

@caseydavenport awesome, thx, I'll be ready!

caseydavenport · 2018-11-07T00:49:25Z

@jackfrancis I've updated to the new version.

An reason the circle tests don't seem to be reporting?

jackfrancis · 2018-11-07T00:57:59Z

@caseydavenport just takes a while :)

These tests don't validate calico + Azure CNI, I'll run another round of tests and report back. What are we going to do about these dev-versioned images? Do we want to ship with those references?

caseydavenport · 2018-11-07T01:50:33Z

What are we going to do about these dev-versioned images? Do we want to ship with those references?

@jackfrancis If you'd like I can re-tag as something else, but these tags are stable references and IIRC the plan was to ship this for now and update to use Calico v3.4.0 as soon as it is available, which is currently looking like early December.

I'm happy to tag as something else if that's desirable, but ultimately the code is the same.

jackfrancis · 2018-11-07T18:23:02Z

/lgtm

acs-bot · 2018-11-07T18:23:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caseydavenport, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

caseydavenport · 2018-11-08T04:16:23Z

Thanks everyone for the help getting this merged!

* add support for k8s v1.12.0-rc.1 (Azure#3872) * Adding DeleteApp func to AzureClient and returning appObjectID in CreateApp (Azure#3869) * Update AKS base image to 0.15.0 (Azure#3870) * Disable AKS VHD for sovereign clouds (Azure#3874) * disable outbound internet check (Azure#3878) * Optimizing template conditional blocks in K8s templates (Azure#3871) * Enforce windows password complexity requirements in acs-engine client… (Azure#3854) * Enforce windows password complexity requirements in acs-engine client. Azure#2407 Added Windows Agent password complexity check as per guidelines in https://docs.microsoft.com/en-us/windows/security/threat-protection/security-policy-settings/password-must-meet-complexity-requirements. This will prevent generation of arm templates if password complexity for windows vm does not meet the complexity requirements. * Addressing review comments: 1). Adding negative test cases to ensure passwords whose complexity is not met are getting rejected. 2). Error message reworded to convey the password complexity requirements enforced currently by the implemented regex * Adding two test cases - password with 0 length and password same as username * Replace deprecated Azure SDK method calls (Azure#3881) * Adding test case for Generate Cluster ID (Azure#3879) * Add availability zone support for masters (Azure#3864) * use dockerhub.akscn.io in mooncake (Azure#3887) * Update docs for AZ (Azure#3886) * Update docs for AZ * Address comments * E2E - enable focused tests (Azure#3885) * re-enable CSE 50 (Azure#3892) * add support for k8s v1.12.0-rc.2 (Azure#3893) See https://github.com/kubernetes/kubernetes/releases/tag/v1.12.0-rc.2 * Handle iterated subtest execution correctly (Azure#3894) * freshen ubuntu image (Azure#3898) * Actually allow cloudprovider rate limit / backoff disabling (Azure#3891) * Extracting property values to make ARM output variables accessible (Azure#3877) * Fixing unreported gosimple lints (Azure#3901) * Update azure-sdk-for-go to v21.0.0 (Azure#3884) * Update azure-sdk-for-go to v20.2.0 See https://github.com/Azure/azure-sdk-for-go/releases/tag/v20.2.0 * Update azure-sdk-for-go to v21.0.0 See https://github.com/Azure/azure-sdk-for-go/releases/tag/v21.0.0 * Windows dns connectivity - e2e tests (Azure#3760) * Add shortcuts for some common command-line arguments (Azure#3904) * Add zip package to VHD image (Azure#3912) * Add zip package to VHD image * Alphabetize packages to install with apt-get * Update AKS base image to 0.16.0 (Azure#3913) * Stop ginkgo tests after first failure (Azure#3922) * Perform JSON escaping of strings (Azure#3919) * removed duplication of shellQuote function and added test cases. (Azure#3927) * Change 'windowsVersion' to 'imageVersion' in docs for deploying specific windows version (Azure#3928) * Add support for Kubernetes 1.9.11 (Azure#3934) See https://github.com/kubernetes/kubernetes/releases/tag/v1.9.11 * Simplify some upgrader version cases (Azure#3924) * Use `echo -n` to skip adding newline to external command output (Azure#3940) * Add warning message for VMSS master deployments (Azure#3936) * Add Kubernetes 1.12.0 to VHD image (Azure#3942) * Migrating Get Addon By Name and Get Container Index By Name methods (Azure#3938) * Fix accidentally shadowed variable in upgrade cluster. (Azure#3943) * Docs Docs Docs! Adding windowsAgent apimodel parameters (Azure#3939) * change default value for osImage (Azure#3944) * Add support for Kubernetes 1.12.0 (Azure#3918) * ip-masq-agent as addon (Azure#3916) * Update AKS base image to 0.17.0 (Azure#3949) Adds support binaries for Kubernetes 2.0.0 and 1.9.11. * Move utility methods to the helper package (Azure#3948) * exit 3 means resource group doesn’t exist (Azure#3954) * AKS distro is for Kubernetes only (Azure#3951) * use westus2 for swarm tests (Azure#3956) * add basic distro tests for swarm, swarmmode, dcos (Azure#3957) * Update go-dev tools image for go 1.11.1 (Azure#3947) * Refactor VM prefix to template functions (Azure#3925) * Migrating cloud spec config to api package (Azure#3953) * Accelerated networking for Windows (Azure#3908) * Add support for Kubernetes 1.12.1 (Azure#3963) * Cleanup Packer directory after VHD build (Azure#3964) * can't move the same file twice (Azure#3965) * sudo sudo sudo (Azure#3967) * retain existing AKS SNAT implementation (Azure#3966) * create cgroups needed by kubelet's --system-reserved and --kube-reserved flags (Azure#3915) * Dont set default distro when OSType is Windows (Azure#3950) * vmss needs systemConf too (Azure#3970) * update AKS VHD image to ver 0.18.0 (Azure#3969) * Fix urls to gofi.sh (Azure#3973) * Strengthen unit tests for cluster ID (Azure#3972) * optimize customData payload by removing comments (Azure#3971) * bump default from 1.8 to 1.10 (Azure#3946) * Using local rand object to generate cluster ids (Azure#3978) * Update node-labels to 1.6+ standard (Azure#3980) * E2E: retry kubectl delete job (Azure#3981) * E2E: actually fail when no InternalIP, ssh master tweaks, delete retries (Azure#3982) * 1.12 uses coredns (Azure#3987) * Refactor: Moving set defaults logic from package acsengine to package api (Azure#3974) * Enable the kubelet-monitor systemd unit (Azure#3983) * k8s component tests should happen before api tests (Azure#3991) * add kubernetes1.12 example (Azure#3992) * gosimple fixes (Azure#3993) * Azure CNI v1.0.12 (Azure#3989) * bump etcd version (Azure#3975) * swarmm = swarm mode (Azure#3995) * Update apiversion to make it consistent in k8s templates (Azure#3909) * E2E: set stability iterations to 10 by default (Azure#3997) * kube-dns 1.14.13 for k8s 1.8 and up (Azure#4004) * update kubernetes-dashboard to 1.10 (Azure#4005) * only schedule coredns pods on a linux node (Azure#4014) * add coredns image reference to components versions map (Azure#3998) * Remove redundant exechealthz references (Azure#4012) * health-monitor script doesn’t require docker (Azure#4028) * Updating the tag for omsagent container to use the latest production tag (Azure#4015) * Replace docker images with the official releases. (Azure#4026) * Fix linter errors reported by gosimple (Azure#4031) * Split Windows setup scripts, prepare for cleanup and multiple CRI (Azure#3994) * Image version bump (Azure#4033) * Doc style, minor updates pass (Azure#4017) * acsengine and deploy pass * Clean up the main README * pass over the kubernetes walkthrough doc - I think maybe just azure specific bits should stay here? * Review changes * Fix typo in prometheus-grafana-k8s extension (Azure#4039) * Add support for Kubernetes 1.10.9 (Azure#4040) See https://github.com/kubernetes/kubernetes/releases/tag/v1.10.9 * Add support for Kubernetes v1.13.0-alpha.1 (Azure#4036) * Fix the Authorization and ManagedIdentity api versions (Azure#4048) * schedule ip-masq-agent on masters (Azure#4049) * delay docker and kubelet health monitors for 30 mins (Azure#4050) * Don't block on Kubernetes installation cleanup operations (Azure#4056) * update to latest AKS VHD image (Azure#4054) * set default masterSubnet value for custom VNET (Azure#4058) * Updating oms agent tag to use the latest tag released (Azure#4059) * Don't test k8s 1.8 or 1.9 in CircleCI (Azure#4061) * Don't test k8s 1.8 or 1.9 in CircleCI * Add k8s 1.13 jobs to build_and_test_master task Also reordered the jobs so that maintainers are less likely to forget about adding both Linux and Windows jobs. * Azure CNI 1.0.12 should be in VHD image (Azure#4067) * 16.04:latest by default for Ubuntu distro flows (Azure#4068) * E2E: enable pod-svc connection test (Azure#4062) * E2E: reuse long-running apache pod, HPA stabilization (Azure#4073) * Update doc: keyvault-flexvol addon default flag (Azure#4072) * use latest AKS VHD (Azure#4074) * E2E: general hardening (Azure#4079) * test scale down as well (Azure#4087) * remove unused nsg for AKS (Azure#4085) * fix error log message (Azure#4088) * Fix issue where kubernetesDashboard params weren't being added despite e enabling the dashboard addon (Azure#4084) * use latest tag for flexvol versions (Azure#4091) * set FailureActions for docker, kubelet, kubeproxy (Azure#3905) * no more default stability test iterations (Azure#4095) * Update vmss master EncryptionWithExternalKms with userassignedidentity (Azure#4082) * update azure-npm to v1.0.13 (Azure#4094) * apt lock hygiene (Azure#4081) * Add userassignedidentity for EncryptionWithExternalKms (Azure#4089) * use azk8s.cn instead of akscn.io (Azure#4099) * Fix calico for k8s 1.12 (Azure#4090) * enable user-configurable Azure CNI URL (Azure#4097) * Fix standard lb with vmss master (Azure#4101) * Don't require vm tags (Azure#4100) * Moby container runtime (Azure#3896) * minor template optimization in kubernetesmastervarsvmss.t (Azure#4112) * Fix potential nil pointer dereference when VM tags are empty (Azure#4117) * add resilience to nvidia driver install/config (Azure#4113) * don’t timeout for apt (Azure#4121) * only install GPU if docker-engine (Azure#4122) * Make --profiling user configurable (Azure#4114) * suppressing sensitive openssl output (Azure#4123) * Configure Docker Version on Windows (Azure#4119) Tests passed. merging. thanks! * disable kubelet health monitor (Azure#4127) * Add support for Kubernetes v1.13.0-alpha.2 (Azure#4128) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.13.md#v1130-alpha2 * Add support for Kubernetes 1.11.4 (Azure#4130) See https://github.com/kubernetes/kubernetes/releases/tag/v1.11.4 * adjust pagefile size (Azure#4098) * Add support for Kubernetes 1.12.2 (Azure#4131) See https://github.com/kubernetes/kubernetes/releases/tag/v1.12.2 * Add external custom yaml for manifests (Azure#4092) * add AKSDockerEngine distro (Azure#4120) * Adding DOCKER_API_VERSION workaround (Azure#4141) * Adding DOCKER_API_VERSION workaround * Fix extra character added * restore exechealthz references (Azure#4145) * re-use ILB test deployment (Azure#4147) * Enable k8s features by default (Azure#4133) * Enable k8s features by default * Add test * Optimize CSE + FeatureFlags option for run in background (Azure#4104) * add VHD images w/ k8s 1.11.4 and k8s 1.12.2 (Azure#4146) * use china mirror in binary downloading (Azure#4137) * Make windows binary url configurable (Azure#4103) * Move the role assignment to the ARM template and fix api versions (Azure#4032) * Merging kubernetesmastervarsvmss into kubernetesmastervars (Azure#4116) * virtualNetworkName is needed for vmss masters (Azure#4159) * vmss masters listen on firstConsecutiveStaticIP (Azure#4162) * rationalize addons/kube-system e2e checks (Azure#4166) * vmss masters customvnet dependson lb (Azure#4167) * Remove unreachable NSG code (Azure#4164) * move k8s specific params to params_k8s.go (Azure#4156) * delete empty file (Azure#4180) * add Skip functionality for skipped tests (Azure#4181) * Output kernel version during VHD build (Azure#4176) * updated VHDs for aks and aks-docker-engine distros (Azure#4178) * distinct outbound test for mooncake clusters (Azure#4169) * update dependencies to point to latest k8s api release (Azure#4157) * Pre-pull hyperkube in VHD (Azure#4174) * use gcr.azk8s.cn for ip-masq-agent on Azure China (Azure#4190) * remove unnecessary bytes (Azure#4187) * cleanUpContainerImages (Azure#4195) * Add AKS container images to VHD build script (Azure#4194) * Update ip assignment and cert gen for vmss masters (Azure#4193) * Azure CNI v1.0.13 (Azure#4197) * Enable upgrade to next supported Kubernetes version (Azure#3968) * reduce customData overhead via streamlined boilerplate (Azure#4183) * Fix 1.8 cluster config (Azure#4200) * More validations for custom vnet and vmss masters (Azure#4199) * fix cilium cluster config (Azure#4202) * Calico support for azure-vnet-ipam (Azure#4154) * Update VHD image to 2018.11.06 (Azure#4201) * move kubeserviceCidr params to windowsparams tpl (Azure#4203) * Only cleanup AKS container images if cluster is not a hosted master cluster (Azure#4204) * 2 units of errata (Azure#4205) * setting default Images in addon defaults instead of params_k8s.go (Azure#4208) * mount xtables lock in proxy (Azure#4210) * test outbound for URLs that we know we need (Azure#4211) * imagePullPolicy: IfNotPresent for all versioned containers (Azure#4212) * don’t save _output as artifacts (Azure#4214) * fix standard lb (Azure#4217) * ensure N series clusters get aks-docker-engine (Azure#4221) * ensure addon image is overwritten during upgrade (Azure#4224) * Update to Docker 18.09 for Windows (Azure#4223) * ensure validate-dns job doesn’t already exist before creating (Azure#4230) * remove empty customdata yml file (Azure#4231) * adding back in double quotes one at a time (Azure#4235) * azure npm addon has differently named pods (Azure#4237) * E2E: ensure long-running-apache hpa doesn’t already exist before creating (Azure#4232) * Adding c:\tmp as needed to pass Kubernetes tests (Azure#4240) * up image to 1108 (Azure#4239) * Add no outbound internet feature flag (Azure#4222) * update azure-const.sh with new location of azure constants python file (Azure#4247) * Tigera Technical Advisory TTA-2018-001 (Azure#4244) * Enable pre-rendering of Container addons (Azure#4218) * Make orchestrator command Windows aware (Azure#4142) * Enable multiple Windows vmss agent pools - refactor pool names (Azure#3907) * consistent use of kubernetes image base (Azure#4233) * remove extraneous sed statements for mooncake (Azure#4253) * Add exechealthz to 1.12/13 section as 1.11 or earlier (Azure#4252) * append bug means we aren’t cleaning up! (Azure#4255) * *string PrincipalID needs to be nil-guarded (Azure#4258) * fix retrycmd_if_failure: $retries should be $r (Azure#4263) * Add DockerEngine feature flag (Azure#4262) * updating azureconst and adding PB6 skus (Azure#4265) * Fix outbound connection check for master VMSS (Azure#4267) * use mcr repos and disable smb flexvol addon (Azure#4266) * bash func definition needs () without “function” (Azure#4269) * Replace docker engine feature flag by existing cloud spec (Azure#4270) * remove DockerEngine FeatureFlag (Azure#4275) * E2E: rationalize node check + kube-system check, no kms (Azure#4273) * install gpu drivers before extracting hyperkube (Azure#4276) * [docs] Add documentation for GPU w/ docker-engine (Azure#4268) * Windows e2e scale up / down test Fixes#3632 (Azure#4264) * remove dead code. (Azure#4282) * remove one extra english paragraph in zh-cn readme. (Azure#4281) * rollback k8s client-go deps to v7.0.0 (Azure#4291) * Fix issue caused by updating azure.json (Azure#4279) * enable typha and add horizontal autoscaler (Azure#4290) * feat(perf): Invoke-WebRequest much slower then browser download (Azure#4294) * Set progresspreference to avoid progress bar and speed up downloads (Azure#4300) * Ensure we do have an error before testing it (Azure#4301) * update client-go to v9 (Azure#4296) * Update to Azure-CNI v1.0.14 (Azure#4297) * Make AvailabilitySet profile for master use Availability Zones (Azure#4286) * Updates from aks-engine spike (Azure#4302) * Fix prow set up * e2e changes * removing openshift artifacts * accelerated networking rationalization, with tests * remove additional sed statements for ip-masq addons * Update go-dev tools image for go 1.11.2 * remove unused azconst methods * add support PB6 vm skus * update azure_const unit test * update tiller versions in the recent versions of kubernetes * VSTS VHD pipeline hosted ubuntu pool * azureconst cruft * scale: persist scale down in api model * Add support for Kubernetes 1.11.5 * Fix docker-engine install in VHD pipeline * remove IsOpenShift from E2E * replace premature aks-engine reference * make validate-headers doesn’t exist, revert rename * all outbound checks are retried (Azure#4304) * fix bunch of warnings for arm templates. (Azure#4285) * Adding doc on how to set Azure CNI versions (Azure#4293) * Support Windows Server 2019 and make it default (Azure#4299) * fix malformed clusterautoscaler yaml bug (Azure#4322) * update kubernetes api to 1.12.3 (Azure#4315) * Prune non-go files from vendoring (Azure#4320) * Prune non-go files from vendoring * Work around errors from gosimple linter * Bump cluster-autoscaler to recommended version for 1.11.5 (Azure#4314) * Add kubelet system-reserved on Windows (Azure#3999) * Add system-reserved on Windows * Remove extra quotes * Add system-reserved on Windows * Update to match usage in #69960 * Re-escape quotes * Just add system reserved as planned at 2Gb * Bump VHD version to 2018.11.28 (Azure#4323) * Add test for docker based workflow (ContainerInventory) (Azure#4198) * Add copyright headers to source files (Azure#4324) * Add Copyright header * Add Copyright header to more files * Rearrange finicky package comments and enforce validate-headers in CI * Remove some extraneous diffs * Rename Makefile target to be more descriptive * deprecation notice (Azure#4335) * Use 2018.12.03 VHD images (Azure#4333) * we need newline (Azure#4341) * [BUG] orchestratorVersion should not get changed for ACS scale apiVersion 2017-07-01 (Azure#4346) * Enable Azure CNI 1.0.15 (Azure#4361) * clarified docs (Azure#4362) * chore: add config for "stale" bot service (Azure#4364) * chore: add config for "stale" bot service * fix: make PRs stale after a week This repo is deprecated and shouldn't be getting any PRs. * fix: rename stale config to have ".yml" extension

acs-bot added the size/M label Oct 31, 2018

caseydavenport commented Oct 31, 2018

View reviewed changes

parts/k8s/addons/kubernetesmasteraddons-calico-daemonset.yaml Show resolved Hide resolved

jackfrancis added the aks label Nov 1, 2018

feiskyer reviewed Nov 5, 2018

View reviewed changes

ghost assigned jackfrancis Nov 5, 2018

ghost added the in progress label Nov 5, 2018

jackfrancis force-pushed the casey-azure branch from 938872c to 7653b6b Compare November 5, 2018 17:19

acs-bot added size/L and removed size/M labels Nov 5, 2018

jackfrancis reviewed Nov 6, 2018

View reviewed changes

feiskyer reviewed Nov 6, 2018

View reviewed changes

caseydavenport and others added 5 commits November 6, 2018 19:30

Calico support for azure-vnet-ipam

93ff588

Set IPAM config based on specified network plugin

073f2f9

fix validation test, pass networkPolicy to CSE

88a2c6e

All k8s versions support Calico network policy + Azure networking

2423bb0

Update Calico CNI version

f39f0dd

caseydavenport force-pushed the casey-azure branch from f5c19cd to f39f0dd Compare November 7, 2018 03:32

acs-bot added the lgtm label Nov 7, 2018

acs-bot added the approved label Nov 7, 2018

jackfrancis merged commit 543ddec into Azure:master Nov 7, 2018

ghost removed the in progress label Nov 7, 2018

caseydavenport deleted the casey-azure branch November 7, 2018 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Calico support for azure-vnet-ipam #4154

Calico support for azure-vnet-ipam #4154

caseydavenport commented Oct 31, 2018 •

edited

Loading

msftclas commented Oct 31, 2018 •

edited

Loading

caseydavenport Oct 31, 2018

caseydavenport Nov 3, 2018

feiskyer Nov 5, 2018

caseydavenport commented Oct 31, 2018

jackfrancis commented Nov 1, 2018

caseydavenport commented Nov 2, 2018

feiskyer left a comment

feiskyer commented Nov 5, 2018

codecov bot commented Nov 5, 2018 •

edited

Loading

jackfrancis commented Nov 5, 2018

jackfrancis commented Nov 5, 2018

caseydavenport commented Nov 5, 2018

caseydavenport commented Nov 5, 2018

jackfrancis Nov 6, 2018

jackfrancis commented Nov 6, 2018

feiskyer left a comment

jackfrancis commented Nov 6, 2018

caseydavenport commented Nov 6, 2018

jackfrancis commented Nov 6, 2018

caseydavenport commented Nov 6, 2018

jackfrancis commented Nov 6, 2018

caseydavenport commented Nov 7, 2018

jackfrancis commented Nov 7, 2018

caseydavenport commented Nov 7, 2018

jackfrancis commented Nov 7, 2018

acs-bot commented Nov 7, 2018

caseydavenport commented Nov 8, 2018

Calico support for azure-vnet-ipam #4154

Calico support for azure-vnet-ipam #4154

Conversation

caseydavenport commented Oct 31, 2018 • edited Loading

msftclas commented Oct 31, 2018 • edited Loading

caseydavenport Oct 31, 2018

Choose a reason for hiding this comment

caseydavenport Nov 3, 2018

Choose a reason for hiding this comment

feiskyer Nov 5, 2018

Choose a reason for hiding this comment

caseydavenport commented Oct 31, 2018

jackfrancis commented Nov 1, 2018

caseydavenport commented Nov 2, 2018

feiskyer left a comment

Choose a reason for hiding this comment

feiskyer commented Nov 5, 2018

codecov bot commented Nov 5, 2018 • edited Loading

Codecov Report

jackfrancis commented Nov 5, 2018

jackfrancis commented Nov 5, 2018

caseydavenport commented Nov 5, 2018

caseydavenport commented Nov 5, 2018

jackfrancis Nov 6, 2018

Choose a reason for hiding this comment

jackfrancis commented Nov 6, 2018

feiskyer left a comment

Choose a reason for hiding this comment

jackfrancis commented Nov 6, 2018

caseydavenport commented Nov 6, 2018

jackfrancis commented Nov 6, 2018

caseydavenport commented Nov 6, 2018

jackfrancis commented Nov 6, 2018

caseydavenport commented Nov 7, 2018

jackfrancis commented Nov 7, 2018

caseydavenport commented Nov 7, 2018

jackfrancis commented Nov 7, 2018

acs-bot commented Nov 7, 2018

caseydavenport commented Nov 8, 2018

caseydavenport commented Oct 31, 2018 •

edited

Loading

msftclas commented Oct 31, 2018 •

edited

Loading

codecov bot commented Nov 5, 2018 •

edited

Loading