Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts/tigera-operator/kubernetes-services-endpoint): quote port #8865

Conversation

simonostendorf
Copy link
Contributor

@simonostendorf simonostendorf commented May 30, 2024

Description

fixes installation of calico tigera-operator with kubernetes-service-endpoint set.

Currently the following error occurs: ConfigMap in version "v1" cannot be handled as a ConfigMap: json: cannot unmarshal number into Go struct field ConfigMap.data of type string

Related issues/PRs

none

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Helm: Fix rendering of KUBERNETES_SERVICE_PORT

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@simonostendorf simonostendorf requested a review from a team as a code owner May 30, 2024 11:09
@marvin-tigera marvin-tigera added this to the Calico v3.29.0 milestone May 30, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels May 30, 2024
@CLAassistant
Copy link

CLAassistant commented May 30, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport caseydavenport added docs-not-required Docs not required for this change merge-when-ready labels May 30, 2024
@marvin-tigera marvin-tigera removed the docs-pr-required Change is not yet documented label May 30, 2024
@marvin-tigera marvin-tigera merged commit 716abfb into projectcalico:master May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants