Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.28] Manual pick #8827: Improve cni-plugin binary install verification #8844

Conversation

ialidzhikov
Copy link
Contributor

Cherry pick of #8827 on release-v3.28.

#8827: Improve cni-plugin binary install verification

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Improve cni-plugin binary install verification.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Verify all installed binaries to make sure they were copied correctly.
@ialidzhikov ialidzhikov requested a review from a team as a code owner May 21, 2024 07:53
@marvin-tigera marvin-tigera added this to the Calico v3.28.1 milestone May 21, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels May 21, 2024
@ialidzhikov ialidzhikov changed the title [CORE-10412] Improve cni-plugin binary install verification [release-v3.28] Manual pick 8827: Improve cni-plugin binary install verification May 21, 2024
@ialidzhikov ialidzhikov changed the title [release-v3.28] Manual pick 8827: Improve cni-plugin binary install verification [release-v3.28] Manual pick #8827: Improve cni-plugin binary install verification May 21, 2024
@caseydavenport caseydavenport added docs-not-required Docs not required for this change merge-when-ready labels May 21, 2024
@marvin-tigera marvin-tigera removed the docs-pr-required Change is not yet documented label May 21, 2024
@caseydavenport
Copy link
Member

/sem-approve

@marvin-tigera marvin-tigera merged commit 46625cf into projectcalico:release-v3.28 May 21, 2024
2 checks passed
@ialidzhikov ialidzhikov deleted the release-v3.28-cherry-pick-8827 branch May 22, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants