Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-10412] Improve cni-plugin binary install verification #8827

Merged
merged 1 commit into from
May 15, 2024

Conversation

coutinhop
Copy link
Member

Verify all installed binaries to make sure they were copied correctly.

Description

Related issues/PRs

fixes #8818

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Improve cni-plugin binary install verification.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Verify all installed binaries to make sure they were copied correctly.
@coutinhop coutinhop added release-note-required Change has user-facing impact (no matter how small) docs-not-required Docs not required for this change labels May 15, 2024
@coutinhop coutinhop self-assigned this May 15, 2024
@coutinhop coutinhop requested a review from a team as a code owner May 15, 2024 18:54
@marvin-tigera marvin-tigera added this to the Calico v3.29.0 milestone May 15, 2024
@coutinhop coutinhop merged commit d30a44c into projectcalico:master May 15, 2024
2 checks passed
@coutinhop coutinhop deleted the pedro-CORE-10412 branch May 15, 2024 21:05
marvin-tigera added a commit that referenced this pull request May 21, 2024
[release-v3.28] Manual pick #8827: Improve cni-plugin binary install verification
marvin-tigera added a commit that referenced this pull request May 21, 2024
[release-v3.27] Manual pick #8827: Improve cni-plugin binary install verification
marvin-tigera added a commit that referenced this pull request May 21, 2024
[release-v3.26] Manual pick #8827: Improve cni-plugin binary install verification
@coutinhop coutinhop added cherry-pick-completed PR has been cherry-picked and removed cherry-pick-candidate labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed PR has been cherry-picked docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation for calico CNI binaries does not work anymore
4 participants