Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPF] host can access self via a service without CTLB #8564

Conversation

tomastigera
Copy link
Contributor

@tomastigera tomastigera commented Feb 28, 2024

added test for this case

No host source conflict resolution on lo since we cannot tell traffic straight to self from traffic to self via a service. Host connecting to self and connecting to the same self port via a service should be rare, but if that is necessaty, than CTLB is the only option.

fixes #8557

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: host can access self via a service without CTLB

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@tomastigera tomastigera requested a review from a team as a code owner February 28, 2024 00:25
@marvin-tigera marvin-tigera added this to the Calico v3.28.0 milestone Feb 28, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Feb 28, 2024
@tomastigera tomastigera added docs-not-required Docs not required for this change cherry-pick-candidate and removed docs-pr-required Change is not yet documented labels Feb 28, 2024
Copy link
Member

@fasaxc fasaxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo but LGTM

felix/bpf-gpl/tc.c Outdated Show resolved Hide resolved
added test for this case

No host source conflict resolution on lo since we cannot tell traffic
straight to self from traffic to self via a service. Host connecting to
self and connecting to the same self port via a service should be rare,
but if that is necessaty, than CTLB is the only option.
@tomastigera tomastigera force-pushed the tomas-bpf-fix-host-self-no-ctlb branch from 38c7613 to 16582c4 Compare March 2, 2024 05:35
@tomastigera
Copy link
Contributor Author

/merge-when-ready

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

@marvin-tigera marvin-tigera merged commit c0995f9 into projectcalico:master Mar 2, 2024
2 checks passed
@tomastigera tomastigera deleted the tomas-bpf-fix-host-self-no-ctlb branch March 2, 2024 18:21
tomastigera added a commit that referenced this pull request Mar 8, 2024
…v3.27

[release-v3.27] Auto pick #8564: host can access self via a service without CTLB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-candidate docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebpf: host->service->self without CTLB does not work
3 participants