Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Unify Soulflayer NM skill list IDs + remove skill lists from non-combat mobs #584

Merged
merged 1 commit into from
May 6, 2020

Conversation

ibm2431
Copy link
Contributor

@ibm2431 ibm2431 commented May 4, 2020

(Look at mob_skill_lists first to understand the diff in mob_pools)

  • Slip in a new skill list for NM Soulflayers right after the skill list for NQ Soulflayers
  • Slide Spheroid, Spider, and "Structure" back by one
  • Discover that "Structure" is a skill list for exoplates, but was also being assigned to random "structure" "mobs" which are non-combat. zero those skill lists out in their pools.
  • Discover that although there isn't a skill list defined for them, pools for SOA reive "mob" structures (roots, nests, etc) have a skill list of 237 defined, zero them out
  • Discovered that pool for Archaic Mirror (not Rampart) was given skill list 238, despite it also being a non-combat structure, zero that out too
  • Finally, assign existing Soulflayer NMs' skill lists to be the new one we're slipping in after the NQs
  • Delete duplicated Soulflayer NM skill lists and free up IDs

@kaincenteno

I affirm:

INSERT INTO `mob_skill_lists` VALUES ('Spider',236,811);
INSERT INTO `mob_skill_lists` VALUES ('Spider',236,812);
INSERT INTO `mob_skill_lists` VALUES ('Structure_Exoplate',237,990);
INSERT INTO `mob_skill_lists` VALUES ('Structure_Exoplate',237,991);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure_Exoplate? Shouldn't that be just Exoplate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that all gravy 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was desperately trying to avoid it no longer being in alphabetical order 💦

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefix all entries with A_, everythings in alphabetical order, problem solved! 😄

Copy link
Contributor

@59blargedy 59blargedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is worse, having it out of numerical order or out of alpha?

@59blargedy 59blargedy merged commit 7fdc91e into release May 6, 2020
@ibm2431 ibm2431 deleted the soulflayer-skill branch May 7, 2020 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants