Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Blue Mage Transformations quest + other 3 armor pieces #545

Merged
merged 3 commits into from
May 12, 2020
Merged

Blue Mage Transformations quest + other 3 armor pieces #545

merged 3 commits into from
May 12, 2020

Conversation

kaincenteno
Copy link
Contributor

@kaincenteno kaincenteno commented Apr 29, 2020

Currently a WIP. Only thing ready is Lathuya's logic. I need to verify that the order of the quest is correct, also one thing i am having issues is the zone:registerRegion and onZoneIn for it as i just added a testing print to player to make sure that the area is correct and i do not get any feedback.

I affirm:

  • that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
  • that I've tested my code since the last commit in the PR, and will test after any later commits

@59blargedy 59blargedy added the focus Related to a current project focus label Apr 29, 2020
@ghost ghost added the WIP PR is a work in progress, remove when its ready label Apr 29, 2020
@kaincenteno
Copy link
Contributor Author

I'm done with the quest 🐱

Only thing missing are:

  • 2 mob attacks for the NM that are missing, there were 3 missing attacks before but added one weird one that removes all buffs lol.
  • correct location params for onRegionEnter for both optional cutscenes. Since they were options i didn't think it was really a stopped.

Now I'm at the mercy of a review. Please @UynGH @59blargedy remove the WIP tag and change it to ready for review 🐈

@ghost ghost added review ready and removed WIP PR is a work in progress, remove when its ready labels Apr 30, 2020
@ibm2431 ibm2431 self-assigned this May 4, 2020
@ibm2431
Copy link
Contributor

ibm2431 commented May 4, 2020

You'll have a dedicated skill list ID to use after #584

Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always remember that I ❤️ you kain~

(I especially want to make sure that Lathuya is solid because I suspect that her logic will be copy-pasted to other craftable AF jobs)

scripts/zones/Aht_Urhgan_Whitegate/npcs/Waoud.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Waoud.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Waoud.lua Outdated Show resolved Hide resolved
sql/mob_pools.sql Outdated Show resolved Hide resolved
sql/mob_skill_lists.sql Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Lathuya.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Lathuya.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Lathuya.lua Outdated Show resolved Hide resolved
scripts/zones/Aht_Urhgan_Whitegate/npcs/Lathuya.lua Outdated Show resolved Hide resolved
scripts/zones/Alzadaal_Undersea_Ruins/Zone.lua Outdated Show resolved Hide resolved
@ibm2431 ibm2431 added hold Requests have been made to merge and removed review ready labels May 5, 2020
Only thing missing are set the onRegionEnter zone correctly and add 2 mob skills that are missing from soulflayers (and this nm too)
@kaincenteno
Copy link
Contributor Author

I'm burnt out after writing this quest. Please make the required changes.
Sorry for my candor.
I'll try to focus on small quests from now on.

@ibm2431
Copy link
Contributor

ibm2431 commented May 7, 2020

Sure thing! Things like this can be pretty grinding.

You're not in this all by yourself~!

@ibm2431
Copy link
Contributor

ibm2431 commented May 11, 2020

Pushed a commit to flip the "orientation" of the charVars for AF crafting to start at max and go towards zero, making sure all associated vars are gone when the player has crafted all the AF pieces.

And I tested it too! I have made sure that my changes didn't break kain's code and cause this to happen:
discord

As it's my own code, I'll tag @cocosolos in case they want to look at the most recent commit.

I intend to push another commit later for the other small things (hopefully tomorrow) .

function onTrade(player, npc, trade)
local remainingBLUAF = player:getCharVar("[BLUAF]Remaining") -- Bitmask of AF the player has NOT crafted
if remainingBLUAF >= 1 then
local currentTask = player:getCharVar("LathuyaCurrentTask_Mask")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being used anywhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it was but I guess I accidentally left it in there when reworking it; will remove. Nice eye~!

@ibm2431
Copy link
Contributor

ibm2431 commented May 12, 2020

Pushed a second commit for various fixes and cleanup, including the Undersea regions and CSes. Had to rework Waoud and Whitegate a little after trying them as non-BLU and naked (respectively) caused unexpected behavior.

I set the Soulflayer to use the skill list ID that will be available to it in release. This branch is way overdue for a update from release (switching to it stills need to deal with non-ignored confs). I'll do that merge after this PR is merged into blue-mage, and I'll uncomment Reprobation then.

I'm okay with merging this without Immortal Shield and Immoral Mind being scripted. We can add those later (after some testing on retail for Immortal Mind). Can potentially hold off on a blue-mage -> canary merge if those two missing skills are a concern for balance/"earn it" reasons.

@ibm2431 ibm2431 added merge ready reviewed and deemed ready to merge and removed hold Requests have been made to merge labels May 12, 2020
@ibm2431 ibm2431 merged commit 26e04af into project-topaz:blue-mage May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus Related to a current project focus merge ready reviewed and deemed ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants