-
Notifications
You must be signed in to change notification settings - Fork 221
Blue Mage Transformations quest + other 3 armor pieces #545
Blue Mage Transformations quest + other 3 armor pieces #545
Conversation
I'm done with the quest 🐱 Only thing missing are:
Now I'm at the mercy of a review. Please @UynGH @59blargedy remove the WIP tag and change it to ready for review 🐈 |
You'll have a dedicated skill list ID to use after #584 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always remember that I ❤️ you kain~
(I especially want to make sure that Lathuya is solid because I suspect that her logic will be copy-pasted to other craftable AF jobs)
Only thing missing are set the onRegionEnter zone correctly and add 2 mob skills that are missing from soulflayers (and this nm too)
I'm burnt out after writing this quest. Please make the required changes. |
Sure thing! Things like this can be pretty grinding. You're not in this all by yourself~! |
Pushed a commit to flip the "orientation" of the charVars for AF crafting to start at max and go towards zero, making sure all associated vars are gone when the player has crafted all the AF pieces. And I tested it too! I have made sure that my changes didn't break kain's code and cause this to happen: As it's my own code, I'll tag @cocosolos in case they want to look at the most recent commit. I intend to push another commit later for the other small things (hopefully tomorrow) . |
function onTrade(player, npc, trade) | ||
local remainingBLUAF = player:getCharVar("[BLUAF]Remaining") -- Bitmask of AF the player has NOT crafted | ||
if remainingBLUAF >= 1 then | ||
local currentTask = player:getCharVar("LathuyaCurrentTask_Mask") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it was but I guess I accidentally left it in there when reworking it; will remove. Nice eye~!
Pushed a second commit for various fixes and cleanup, including the Undersea regions and CSes. Had to rework Waoud and Whitegate a little after trying them as non-BLU and naked (respectively) caused unexpected behavior. I set the Soulflayer to use the skill list ID that will be available to it in I'm okay with merging this without Immortal Shield and Immoral Mind being scripted. We can add those later (after some testing on retail for Immortal Mind). Can potentially hold off on a |
Currently a WIP. Only thing ready is Lathuya's logic. I need to verify that the order of the quest is correct, also one thing i am having issues is the zone:registerRegion and onZoneIn for it as i just added a testing print to player to make sure that the area is correct and i do not get any feedback.
I affirm: