make all NMs not charmable

[KnowOne134]

I affirm:

• that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
• that I've tested my code since the last commit in the PR, and will test after any later commits

not all NMs were being tagged on initialize for being uncharmable. this will correct that.
if you need a NM to be charmable will have to tag it with mobMod Charmable, 1 anywhere in script beside onMobInitialize

[TeoTwawki]

Would be better to have the nm check in the other place you removed it from before so that the mobmod can work even in onmobinit. It just needed correct syntax to exempt nms that had the mobmod
https://github.com/project-topaz/topaz/pull/332/files#diff-1edaebbb5ff57fedc3a066c6ae7c62fdL3829

[ibm2431]

I know you're appending NMs to where the charmable mod already is, but should this assignment be in calculateStats?

I could be wrong, but LoadMOBList might be a better candidate, as it's already attempting to set the charmable mod, and it occurs before the call to InitializeMob, so I want to say onMobInitialize should be able to overwrite the default assignment.

If I'm reading this right, instance_loader might need to be modified too.

[KnowOne134]

Should I delete all this logic and move to instance loader and zone loader?

topaz/src/map/utils/mobutils.cpp

Line 564 in 8985d2a

if(PMob->m_Type & MOBTYPE_EVENT || PMob->m_Type & MOBTYPE_FISHED || PMob->m_Type & MOBTYPE_BATTLEFIELD ||

[KnowOne134]

As it is I'm just adding to an already in place system

[ibm2431]

I think that setting charm mod should never have been in calculateStats. The function is used to recalculate mob stats depending on the level chosen when a mob spawns. Whether or not a mob is charmable isn't really a "stat" - it never changes from spawn-to-spawn. And as you pointed out, it occurs after mobInitialize, and I feel we shouldn't need to deliberately use a different lua function to overwrite the charm mod simply because core's assignment is in the wrong place.

[KnowOne134]

Looks good