Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #66 - Constants to data #71

Merged
merged 6 commits into from
Jun 22, 2022
Merged

fix #66 - Constants to data #71

merged 6 commits into from
Jun 22, 2022

Conversation

michalstruck
Copy link
Contributor

Renamed file didn't need typing, as it's all easily inferred as string. Closes #66.

@umairwaheed
Copy link
Member

umairwaheed commented Jun 20, 2022

@michalstruck thanks for submitting a PR. Can you please resolve conflicts?

@michalstruck
Copy link
Contributor Author

Done

@umairwaheed
Copy link
Member

@michalstruck I am getting the following error when I try to run yarn dev. This happens on portfolio page. This error doesn't happen on upstream/master branch.

ReferenceError: Box is not defined
  11 |     <div className="portfolio-page">
  12 |       <Header bgImg={homePageBg} title={title}>
> 13 |         <Box className="careers-container">
     |         ^
  14 |           <Typography
  15 |             variant="h2"
  16 |             textAlign="center"

Copy link
Member

@umairwaheed umairwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error that needs to be fixed.

@michalstruck
Copy link
Contributor Author

Check now? I don't get any console errors now, sorry for earlier.

Copy link
Member

@umairwaheed umairwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umairwaheed umairwaheed merged commit f2966bd into prixite:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change constants to data
2 participants