-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #66 - Constants to data #71
Conversation
@michalstruck thanks for submitting a PR. Can you please resolve conflicts? |
Done |
@michalstruck I am getting the following error when I try to run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an error that needs to be fixed.
Check now? I don't get any console errors now, sorry for earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Renamed file didn't need typing, as it's all easily inferred as string. Closes #66.