Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change constants to data #66

Closed
3 tasks
Tracked by #67
umairwaheed opened this issue Jun 17, 2022 · 0 comments · Fixed by #71
Closed
3 tasks
Tracked by #67

Change constants to data #66

umairwaheed opened this issue Jun 17, 2022 · 0 comments · Fixed by #71
Labels
good first issue Good for newcomers

Comments

@umairwaheed
Copy link
Member

umairwaheed commented Jun 17, 2022 •
edited
Loading

Change constants.js to data/data.ts.

  • Rename filename
  • Change code to TypeScript.
  • Change references in the codebase.
@umairwaheed umairwaheed added the good first issue Good for newcomers label Jun 17, 2022
@umairwaheed umairwaheed mentioned this issue Jun 17, 2022
Closed
1 task
@michalstruck michalstruck mentioned this issue Jun 19, 2022
Merged
umairwaheed pushed a commit that referenced this issue Jun 22, 2022
@michalstruck
fix #66 - Constants to data (#71)
f2966bd 
* fix: file typed

* final

* fix: changed constants to data, updated imports

* chore: added missing imports, removed unused ones
@umairwaheed umairwaheed linked a pull request Jun 23, 2022 that will close this issue
Changed constants folder name to data #83
Merged
@umairwaheed umairwaheed removed a link to a pull request Jun 23, 2022
Changed constants folder name to data #83
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #66 - Constants to data
1 participant
@umairwaheed