Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to pnpm 9 #5077

Merged
merged 3 commits into from
Dec 6, 2024
Merged

chore: upgrade to pnpm 9 #5077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9c0790
chore: upgrade to pnpm 9
aqrln Dec 5, 2024
80f8155
update flake for newer pnpm
aqrln Dec 6, 2024
9dd15c9
Don't filter the packages to install
aqrln Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-driver-adapters-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: "Setup pnpm"
uses: pnpm/action-setup@v4.0.0
with:
version: 8
version: 9

- name: "Login to Docker Hub"
uses: docker/login-action@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wasm-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: "Setup pnpm"
uses: pnpm/action-setup@v4.0.0
with:
version: 8
version: 9

- name: "Login to Docker Hub"
uses: docker/login-action@v3
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ build-driver-adapters-kit: build-driver-adapters

build-driver-adapters: ensure-prisma-present
@echo "Building driver adapters..."
@cd ../prisma && pnpm --filter "*adapter*" i
@cd ../prisma && pnpm i
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a needed change? I imagine it'll increase the CI time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was failing even after updating to pnpm 9 in this PR precisely because of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and it was also the reason i couldn't reproduce locally, because i already had all packages installed in the local checkout)

@echo "Driver adapters build completed.";

ensure-prisma-present:
Expand Down
24 changes: 12 additions & 12 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion nix/shell.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ in

nodejs_20
nodejs_20.pkgs.typescript-language-server
pnpm_8
pnpm_9

binaryen
cargo-insta
Expand Down
2 changes: 1 addition & 1 deletion query-engine/driver-adapters/executor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"engines": {
"node": ">=18.18",
"pnpm": ">=8.6.6"
"pnpm": "^9.14.2"
},
"name": "executor",
"version": "0.0.1",
Expand Down
4 changes: 2 additions & 2 deletions query-engine/driver-adapters/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"version": "0.0.2",
"description": "",
"engines": {
"node": ">=16.13",
"pnpm": ">=8.6.6 <9"
"node": ">=18.18",
"pnpm": "^9.14.2"
},
"license": "Apache-2.0",
"scripts": {
Expand Down
Loading