-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to pnpm 9 #5077
chore: upgrade to pnpm 9 #5077
Conversation
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5077 will not alter performanceComparing Summary
|
@@ -405,7 +405,7 @@ build-driver-adapters-kit: build-driver-adapters | |||
|
|||
build-driver-adapters: ensure-prisma-present | |||
@echo "Building driver adapters..." | |||
@cd ../prisma && pnpm --filter "*adapter*" i | |||
@cd ../prisma && pnpm i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a needed change? I imagine it'll increase the CI time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was failing even after updating to pnpm 9 in this PR precisely because of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and it was also the reason i couldn't reproduce locally, because i already had all packages installed in the local checkout)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a comment
Update the driver adapters tests to use pnpm 9 to match the client repo.