Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to pnpm 9 #5077

Merged
merged 3 commits into from
Dec 6, 2024
Merged

chore: upgrade to pnpm 9 #5077

merged 3 commits into from
Dec 6, 2024

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Dec 5, 2024

Update the driver adapters tests to use pnpm 9 to match the client repo.

@aqrln aqrln requested a review from a team as a code owner December 5, 2024 19:06
@aqrln aqrln requested review from jkomyno and removed request for a team December 5, 2024 19:06
@aqrln aqrln added this to the 6.1.0 milestone Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.050MiB 2.050MiB 0.000B
Postgres (gzip) 821.957KiB 821.958KiB -1.000B
Mysql 2.013MiB 2.013MiB 0.000B
Mysql (gzip) 808.107KiB 808.110KiB -3.000B
Sqlite 1.911MiB 1.911MiB 0.000B
Sqlite (gzip) 768.034KiB 768.035KiB -1.000B

Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #5077 will not alter performance

Comparing pnpm9 (9dd15c9) with main (f211204)

Summary

✅ 11 untouched benchmarks

@@ -405,7 +405,7 @@ build-driver-adapters-kit: build-driver-adapters

build-driver-adapters: ensure-prisma-present
@echo "Building driver adapters..."
@cd ../prisma && pnpm --filter "*adapter*" i
@cd ../prisma && pnpm i
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a needed change? I imagine it'll increase the CI time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was failing even after updating to pnpm 9 in this PR precisely because of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and it was also the reason i couldn't reproduce locally, because i already had all packages installed in the local checkout)

Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment

@aqrln aqrln merged commit f15691e into main Dec 6, 2024
367 checks passed
@aqrln aqrln deleted the pnpm9 branch December 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants