Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Tracking #2694

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Release Tracking #2694

merged 1 commit into from
Mar 18, 2024

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Mar 15, 2024 •
edited
Loading

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/view-components@0.21.0

Minor Changes

  • #2603 bbc1776 Thanks @langermank! - Tooltip visual refresh to match Primer React

  • #2693 852e24f Thanks @camertron! - - Bug fix: inactive button colors

    • Bug fix: double border/box-shadow on popover and dropdown
    • Bug fix: text color for primary button in dark dimmed

Patch Changes

@primer primer bot requested a review from a team as a code owner March 15, 2024 21:14
@primer primer bot requested a review from TylerJDev March 15, 2024 21:14
@github-actions GitHub Actions
Copy link
Contributor

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Lookbook opens in a browser
  • Successful integration test with GitHub.com as a primary consumer of Primer View Components
    • Install the npm release candidate: npm i -w ./npm-workspaces/primer/ @primer/view-components@next
    • Update primer_view_components gem: script/vendor-gem https://github.com/primer/view_components.git -r changeset-release/main
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Manually test critical paths
    • Manually test release-specific bugfixes and/or features work as described

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • All new features in this release have been tested and verified as compatible with GitHub.com
  • No noticeable regressions have been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@primer primer bot force-pushed the changeset-release/main branch from 1cc3a88 to a6d33cb Compare March 18, 2024 20:09
@primer primer bot force-pushed the changeset-release/main branch from a6d33cb to 136d21a Compare March 18, 2024 20:10
@primer primer bot force-pushed the changeset-release/main branch from 136d21a to 6d47fa8 Compare March 18, 2024 21:58
@primer primer bot force-pushed the changeset-release/main branch from 6d47fa8 to 0e01a85 Compare March 18, 2024 23:25
@jonrohan jonrohan merged commit 1417904 into main Mar 18, 2024
31 checks passed
@jonrohan jonrohan deleted the changeset-release/main branch March 18, 2024 23:58
jonrohan pushed a commit that referenced this pull request Mar 27, 2024
@primer @github-actions @jonrohan
Release Tracking (#2694)
34ae8f4 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @jonrohan