Tooltip visual refresh #2603
Merged
Tooltip visual refresh #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 921a5f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
commented
Feb 13, 2024
|
Co-authored-by: Jon Rohan <rohan@github.com>
Comment on lines
113
to
120
| :host:after{ | ||
| position: absolute; | ||
| display: block; | ||
| right: 0; | ||
| left: 0; | ||
| height: 12px; | ||
| content: ""; | ||
| } |
There was a problem hiding this comment.
I think we need this too keep the tooltip open when cursor leaves the trigger to hover the tooltip text.
Comment on lines
150
to
154
| :host(.tooltip-s):after, | ||
| :host(.tooltip-se):after, | ||
| :host(.tooltip-sw):after { | ||
| bottom: 100% | ||
| } |
There was a problem hiding this comment.
I think these ::after classes are still needed to position the empty content that I mentioned here about hovering the tooltip text
Comment on lines
161
to
165
| :host(.tooltip-n):after, | ||
| :host(.tooltip-ne):after, | ||
| :host(.tooltip-nw):after { | ||
| top: 100%; | ||
| } |
There was a problem hiding this comment.
keithamus
reviewed
Feb 14, 2024
camertron
approved these changes
Mar 18, 2024
Merged
jonrohan
added a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: langermank <langermank@users.noreply.github.com> Co-authored-by: Jon Rohan <rohan@github.com> Co-authored-by: Cameron Dutro <camertron@gmail.com> Co-authored-by: camertron <camertron@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Match the updated design we're drafting in Primer React. Check out the design docs for more details.
Integration
Bump PCSS
Risk Assessment
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.