Docs: update accessibility section of PVC Banner #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc74138 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
khiga8
commented
Feb 20, 2024
Comment on lines
22
to
26
| # Focusing a Banner when it appear helps to maximize discoverability of the message, especially in critical scenarios. | ||
| # | ||
| # To properly focus a banner, add a `tabindex="-1"` to the Banner container, and focus that container (one way is using the [`focus()` API](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus)). | ||
| # | ||
| # For more information about the focus management technique, visit the [Staff only: Accessible Banner Prototype docs](https://github.com/github/accessibility/blob/main/docs/coaching-recommendations/toast-flash-banner/accessible-banner-prototype.md#consideration). This guidance is subject to change. |
There was a problem hiding this comment.
Focus content should not have changed, except I added a Staff only to the link!
Co-authored-by: Lindsey Wild <35239154+lindseywild@users.noreply.github.com>
lindseywild
approved these changes
Feb 20, 2024
camertron
requested changes
Feb 20, 2024
Co-authored-by: Cameron Dutro <camertron@gmail.com>
Co-authored-by: Cameron Dutro <camertron@gmail.com>
|
Accepted your suggestions! Thanks for reviewing @camertron! |
|
Looks like we're seeing some breakage because of a change to Rails main. I'm going to merge this and address those failures in a follow-up PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
The Banner currently lacks accessibility guidance, and we've seen Banner come up in a few audit issues.
To help unblock existing audit issues and to prevent future audit issues, this PR provides accessibility guidance including:
List the issues that this change affects.
Fixes: https://github.com/github/accessibility/issues/5649
Risk Assessment
be resolved below.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.