Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Banner] Render Banner as a region landmark labelled by a heading by default #2619

Closed
khiga8 opened this issue Feb 20, 2024 · 1 comment
Closed
Labels
accessibility rails Stale Automatically marked as stale.

Comments

@khiga8
Copy link
Contributor

khiga8 commented Feb 20, 2024

This is a recommendation that came out of accessible banner exploration.

Given that Banner is made visually prominent to sighted users through the use of icons and color, providing a heading and designating the Banner as a region landmark will significantly improve assistive technology users easily discover and navigate to the Banner. This recommendation is assuming that people aren't overusing Banners on a page.

However, making this a default would be a breaking change to the API for the PVC Banner. Therefore, I'm filing an issue for this to be considered in future investments.

For now, I've opted to update the documentation.

@khiga8 khiga8 changed the title Render Banner as a region landmark labelled by a heading by default [Banner] Render Banner as a region landmark labelled by a heading by default Feb 20, 2024
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Aug 18, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility rails Stale Automatically marked as stale.
Projects
None yet
Development

No branches or pull requests

1 participant