Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix axe checks for RadioButton and CheckBox previews #2319

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

In a recent PR, we exempted the RadioButton and CheckBox previews from axe checking because of a few failures that occurred after upgrading our accessibility checking tools. This PR addresses the issues and re-enables axe checking for these previews.

Integration

No changes necessary in prod.

List the issues that this change affects.

Fixes https://github.com/github/primer/issues/2786

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Lookbook)
- [ ] Tested in Chrome
- [ ] Tested in Firefox
- [ ] Tested in Safari
- [ ] Tested in Edge

@camertron camertron added the skip changeset Pull requests that don't change the library output label Oct 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

⚠️ No Changeset found

Latest commit: d988bf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron merged commit cdcff82 into main Oct 20, 2023
31 checks passed
@camertron camertron deleted the fix_axe_for_radio_and_check_previews branch October 20, 2023 18:13
@camertron camertron temporarily deployed to preview October 20, 2023 18:14 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants