Fix axe checks for RadioButton and CheckBox previews

primer · Oct 20, 2023 · d988bf6 · d988bf6
1 parent 683d931
commit d988bf6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/lib/primer/accessibility.rb b/lib/primer/accessibility.rb
@@ -8,9 +8,7 @@ module Accessibility
     # Do not add to this list for any other reason!
     IGNORED_PREVIEWS = [
       Primer::Beta::MarkdownPreview,
-      Primer::Beta::AutoCompleteItemPreview,
-      Primer::Alpha::RadioButtonPreview,
-      Primer::Alpha::CheckBoxPreview
+      Primer::Beta::AutoCompleteItemPreview
     ].freeze
 
     # Skip `:region` which relates to preview page structure rather than individual component.

diff --git a/previews/primer/alpha/check_box_preview.rb b/previews/primer/alpha/check_box_preview.rb
@@ -7,15 +7,13 @@ class CheckBoxPreview < ViewComponent::Preview
       # @label Playground
       #
       # @param name text
-      # @param id text
       # @param value text
       # @param label text
       # @param caption text
       # @param visually_hide_label toggle
       # @param disabled toggle
       def playground(
         name: "my-check-box",
-        id: nil,
         value: "picard",
         label: "Jean-Luc Picard",
         caption: "Make it so",
@@ -24,7 +22,6 @@ def playground(
       )
         system_arguments = {
           name: name,
-          id: id,
           value: value,
           label: label,
           caption: caption,

diff --git a/previews/primer/alpha/radio_button_preview.rb b/previews/primer/alpha/radio_button_preview.rb
@@ -7,15 +7,13 @@ class RadioButtonPreview < ViewComponent::Preview
       # @label Playground
       #
       # @param name text
-      # @param id text
       # @param value text
       # @param label text
       # @param caption text
       # @param visually_hide_label toggle
       # @param disabled toggle
       def playground(
         name: "my-radio-button",
-        id: nil,
         value: "bsg",
         label: "Battlestar Galactica",
         caption: "A pretty good show",
@@ -24,7 +22,6 @@ def playground(
       )
         system_arguments = {
           name: name,
-          id: id,
           value: value,
           label: label,
           caption: caption,