Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert v8 color var fallbacks #2113

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Revert v8 color var fallbacks #2113

merged 3 commits into from
Jun 28, 2023

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

Reverts #2083

Integration

Requires reverting v0.3.0 in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Reverted commit e38ae1e and fixed merge conflicts.

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 68eac1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added patch release css Pull requests that update CSS code labels Jun 28, 2023
@camertron camertron temporarily deployed to preview June 28, 2023 20:33 — with GitHub Actions Inactive
@camertron camertron marked this pull request as ready for review June 28, 2023 20:38
@camertron camertron requested a review from a team as a code owner June 28, 2023 20:38
@camertron camertron requested review from a team, tobiasahlin and keithamus June 28, 2023 20:38
@camertron camertron temporarily deployed to github-pages June 28, 2023 20:38 — with GitHub Actions Inactive
@camertron camertron merged commit f473634 into main Jun 28, 2023
@camertron camertron deleted the revert_v8_color_var_fallbacks branch June 28, 2023 20:57
@primer-css primer-css mentioned this pull request Jun 28, 2023
Merged
langermank pushed a commit that referenced this pull request Jun 29, 2023
@camertron @langermank
Revert v8 color var fallbacks (#2113)
3822319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@tobiasahlin tobiasahlin Awaiting requested review from tobiasahlin tobiasahlin is a code owner automatically assigned from primer/css-reviewers

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
css Pull requests that update CSS code patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @langermank