Use @primer/primitive v8 color CSS vars with fallbacks
#2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d467d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
changed the title
@primer/primitive v8 color CSS vars with fallbacks
langermank
commented
Jun 21, 2023
| missing_vars = matches.map { |match| match[0] } | ||
| assert_equal 0, matches.length, "CSS variables are missing fallbacks: #{missing_vars.join(', ')}" | ||
| end | ||
| end |
There was a problem hiding this comment.
Here's what the output of this test look likes if it fails
I think since my regex is fuzzy, I can't get the full variable string. If anyone has feedback on how I can make this test failure more clear let me know!
There was a problem hiding this comment.
I added some logic in to point at the line and column so it's easier to find the failure.
jonrohan
approved these changes
Jun 21, 2023
camertron
approved these changes
Jun 21, 2023
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Using Stylelint, this PR replaces all color CSS vars with the new version from Primitives that we're testing behind a feature flag in github/github. PostCSS automatically adds fallback values at build time, and stylelint will ensure we only use new color tokens going forward with linting.
Screenshots
Integration
No, the feature flag is already in place.
List the issues that this change affects.
https://github.com/github/primer/issues/1410
Risk Assessment
What approach did you choose and why?
npm run lint:stylelint:fixand some manual find/replaceAnything you want to highlight for special attention from reviewers?
Please check that the build CSS files all have fallback values (see the build in the checks section)
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.