Use system arguments instead of utility classes for NavList's "show more" item #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3cb8ccd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
requested review from
a team,
keithamus and
jonrohan
and removed request for
keithamus
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NavListfeatures a special "show more" item for lazy loading additional list items. Unfortunately it uses a Primer utility class instead of the corresponding system argument, and is causing an error in dotcom's Lookbook.This would have been caught by our test suite except that we have
raise_on_invalid_optionsset tofalsein the test environment 🤦Closes #1843.
Integration
No. Should be backwards-compatible.
Merge checklist
- [ ] Added/updated previews