Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavList::Section show_more_item slot uses Primer CSS class #1843

Closed
strackoverflow opened this issue Feb 22, 2023 · 2 comments · Fixed by #1845
Closed

NavList::Section show_more_item slot uses Primer CSS class #1843

strackoverflow opened this issue Feb 22, 2023 · 2 comments · Fixed by #1845
Assignees
@camertron
Labels
rails

Comments

@strackoverflow
Copy link
Member

👋 Hello! I am unable to use the show_more_item slot of the NavList::Section component because it is using a Primer CSS class under the hood, which causes the System Arguments exception to throw:

Screenshot 2023-02-22 at 5 57 00 PM

I can try to cut a PR to fix this tomorrow but wanted to flag this!
@jonrohan jonrohan assigned jonrohan and unassigned jonrohan Feb 27, 2023
@camertron camertron self-assigned this Feb 27, 2023
@camertron
Copy link
Contributor

Woops, sorry about this @strackoverflow! I'm taking a look now.

@strackoverflow
Copy link
Member Author

Thank you, I appreciate it!

@camertron camertron mentioned this issue Feb 27, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camertron camertron

Labels
rails
Projects
None yet
Milestone
No milestone
4 participants
@jonrohan @strackoverflow @camertron @lesliecdubs