Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused deprecated component wrappers #1784

Merged
merged 16 commits into from
Jan 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .changeset/shiny-actors-share.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
"@primer/view-components": patch
---

Remove unused deprecated component wrappers

- "Primer::Dropdown::Menu::Item"
- "Primer::Dropdown::Menu"
- "Primer::Dropdown"
- "Primer::HellipButton"
- "Primer::LabelComponent"
- "Primer::LinkComponent"
- "Primer::Markdown"
- "Primer::MenuComponent"
- "Primer::OcticonComponent"
- "Primer::OcticonSymbolsComponent"
- "Primer::PopoverComponent"
- "Primer::SpinnerComponent"
- "Primer::StateComponent"
- "Primer::SubheadComponent"
- "Primer::TabContainerComponent"
- "Primer::TimelineItemComponent::BadgeComponent"
- "Primer::TimelineItemComponent"
7 changes: 0 additions & 7 deletions app/components/primer/dropdown.rb

This file was deleted.

14 changes: 0 additions & 14 deletions app/components/primer/dropdown/menu.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/hellip_button.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/label_component.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/link_component.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/markdown.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/menu_component.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/octicon_component.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/octicon_symbols_component.rb

This file was deleted.

8 changes: 0 additions & 8 deletions app/components/primer/popover_component.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/spinner_component.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/state_component.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/subhead_component.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/components/primer/tab_container_component.rb

This file was deleted.

13 changes: 0 additions & 13 deletions app/components/primer/timeline_item_component.rb

This file was deleted.

10 changes: 5 additions & 5 deletions docs/contributors/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,18 @@ configurations for more information.
1. An autocorrectable deprecation without a migration guide

```yml
- component: "Primer::LabelComponent"
- component: "Primer::DeprecatedComponent"
autocorrect: true
replacement: "Primer::Beta::Label
replacement: "Primer::Beta::Component
```

2. An autocorrectable deprecation with a migration guide to provide more information about the changes

```yml
- component: "Primer::LabelComponent"
- component: "Primer::DeprecatedComponent"
autocorrect: true
replacement: "Primer::Beta::Label
guide: "https://example.com/label_component"
replacement: "Primer::Beta::Component
guide: "https://example.com/primer_component"
```

3. A non-autocorrectable deprecation, with a replacement component and migration guide
Expand Down
68 changes: 0 additions & 68 deletions lib/primer/deprecations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,88 +22,20 @@ deprecations:
replacement: "Primer::Beta::Button"
guide: "https://primer.style/view-components/guides/primer_button_component"

- component: "Primer::Dropdown"
autocorrect: true
replacement: "Primer::Alpha::Dropdown"

- component: "Primer::Dropdown::Menu"
autocorrect: true
replacement: "Primer::Alpha::Dropdown::Menu"

- component: "Primer::Dropdown::Menu::Item"
autocorrect: true
replacement: "Primer::Alpha::Dropdown::Menu::Item"

- component: "Primer::HellipButton"
autocorrect: true
replacement: "Primer::Alpha::HellipButton"

- component: "Primer::IconButton"
autocorrect: true
replacement: "Primer::Beta::IconButton"

- component: "Primer::LabelComponent"
autocorrect: true
replacement: "Primer::Beta::Label"

- component: "Primer::LocalTime"
autocorrect: false
replacement: "Primer::Beta::RelativeTime"
guide: "https://primer.style/view-components/guides/primer_local_time"

- component: "Primer::LinkComponent"
autocorrect: true
replacement: "Primer::Beta::Link"

- component: "Primer::Markdown"
autocorrect: true
replacement: "Primer::Beta::Markdown"

- component: "Primer::MenuComponent"
autocorrect: true
replacement: "Primer::Alpha::Menu"

- component: "Primer::OcticonComponent"
autocorrect: true
replacement: "Primer::Beta::Octicon"

- component: "Primer::OcticonSymbolsComponent"
autocorrect: true
replacement: "Primer::Alpha::OcticonSymbols"

- component: "Primer::PopoverComponent"
autocorrect: true
replacement: "Primer::Beta::Popover"

- component: "Primer::SpinnerComponent"
autocorrect: true
replacement: "Primer::Beta::Spinner"

- component: "Primer::StateComponent"
autocorrect: true
replacement: "Primer::Beta::State"

- component: "Primer::SubheadComponent"
autocorrect: true
replacement: "Primer::Beta::Subhead"

- component: "Primer::TabContainerComponent"
autocorrect: true
replacement: "Primer::Alpha::TabContainer"

- component: "Primer::TimeAgoComponent"
autocorrect: false
replacement: "Primer::Beta::RelativeTime"
guide: "https://primer.style/view-components/guides/primer_time_ago"

- component: "Primer::TimelineItemComponent"
autocorrect: true
replacement: "Primer::Beta::TimelineItem"

- component: "Primer::TimelineItemComponent::BadgeComponent"
autocorrect: true
replacement: "Primer::Beta::TimelineItem::Badge"

- component: "Primer::Tooltip"
autocorrect: true
replacement: "Primer::Alpha::Tooltip"
17 changes: 0 additions & 17 deletions static/audited_at.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,28 +76,11 @@
"Primer::ButtonComponent": "",
"Primer::ConditionalWrapper": "",
"Primer::Content": "",
"Primer::Dropdown": "",
"Primer::Dropdown::Menu": "",
"Primer::Dropdown::Menu::Item": "",
"Primer::HellipButton": "",
"Primer::IconButton": "",
"Primer::LabelComponent": "",
"Primer::LayoutComponent": "",
"Primer::LinkComponent": "",
"Primer::LocalTime": "",
"Primer::Markdown": "",
"Primer::MenuComponent": "",
"Primer::Navigation::TabComponent": "",
"Primer::OcticonComponent": "",
"Primer::OcticonSymbolsComponent": "",
"Primer::PopoverComponent": "",
"Primer::SpinnerComponent": "",
"Primer::StateComponent": "",
"Primer::SubheadComponent": "",
"Primer::TabContainerComponent": "",
"Primer::TimeAgoComponent": "",
"Primer::TimelineItemComponent": "",
"Primer::TimelineItemComponent::BadgeComponent": "",
"Primer::Tooltip": "",
"Primer::Truncate": ""
}
37 changes: 0 additions & 37 deletions static/constants.json
Original file line number Diff line number Diff line change
Expand Up @@ -1033,16 +1033,6 @@
},
"Primer::Content": {
},
"Primer::Dropdown": {
"Menu": "Primer::Dropdown::Menu"
},
"Primer::Dropdown::Menu": {
"Item": "Primer::Dropdown::Menu::Item"
},
"Primer::Dropdown::Menu::Item": {
},
"Primer::HellipButton": {
},
"Primer::IconButton": {
"DEFAULT_SCHEME": "default",
"SCHEME_MAPPINGS": {
Expand All @@ -1054,8 +1044,6 @@
"danger"
]
},
"Primer::LabelComponent": {
},
"Primer::LayoutComponent": {
"ALLOWED_SIDEBAR_COLS": [
1,
Expand All @@ -1078,8 +1066,6 @@
"DEFAULT_SIDEBAR_COL": 3,
"MAX_COL": 12
},
"Primer::LinkComponent": {
},
"Primer::LocalTime": {
"DEFAULT_DIGIT_TYPE": "numeric",
"DEFAULT_TEXT_TYPE": "short",
Expand All @@ -1092,38 +1078,15 @@
"long"
]
},
"Primer::Markdown": {
},
"Primer::MenuComponent": {
},
"Primer::Navigation::TabComponent": {
"ARIA_CURRENT_OPTIONS_FOR_ANCHOR": [
true,
"page"
],
"DEFAULT_ARIA_CURRENT_FOR_ANCHOR": "page"
},
"Primer::OcticonComponent": {
},
"Primer::OcticonSymbolsComponent": {
},
"Primer::PopoverComponent": {
},
"Primer::SpinnerComponent": {
},
"Primer::StateComponent": {
},
"Primer::SubheadComponent": {
},
"Primer::TabContainerComponent": {
},
"Primer::TimeAgoComponent": {
},
"Primer::TimelineItemComponent": {
"BadgeComponent": "Primer::TimelineItemComponent::BadgeComponent"
},
"Primer::TimelineItemComponent::BadgeComponent": {
},
"Primer::Tooltip": {
"ALIGN_DEFAULT": "default",
"ALIGN_MAPPING": {
Expand Down
Loading