Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused deprecated component wrappers #1784

Merged
merged 16 commits into from
Jan 30, 2023
Merged

Remove unused deprecated component wrappers #1784

merged 16 commits into from
Jan 30, 2023

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jan 27, 2023 •
edited
Loading

Description

I'm removing a whole list of deprecated components that are no longer in use on dotcom. These namespaces were used as a symbolic link while we migrated, but all of these components have been migrated to zero.

  • "Primer::Dropdown::Menu::Item"
  • "Primer::Dropdown::Menu"
  • "Primer::Dropdown"
  • "Primer::HellipButton"
  • "Primer::LabelComponent"
  • "Primer::LinkComponent"
  • "Primer::Markdown"
  • "Primer::MenuComponent"
  • "Primer::OcticonComponent"
  • "Primer::OcticonSymbolsComponent"
  • "Primer::PopoverComponent"
  • "Primer::SpinnerComponent"
  • "Primer::StateComponent"
  • "Primer::SubheadComponent"
  • "Primer::TabContainerComponent"
  • "Primer::TimelineItemComponent::BadgeComponent"
  • "Primer::TimelineItemComponent"

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: ba4940e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan temporarily deployed to review-pr-1784 January 27, 2023 18:29 — with GitHub Actions Inactive
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Jan 27, 2023
@jonrohan jonrohan temporarily deployed to github-pages January 27, 2023 18:33 — with GitHub Actions Inactive
@jonrohan jonrohan marked this pull request as ready for review January 27, 2023 19:22
@jonrohan jonrohan requested review from a team and keithamus January 27, 2023 19:22
camertron
camertron approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

@jonrohan jonrohan merged commit 3b83016 into main Jan 30, 2023
@jonrohan jonrohan deleted the remove_deprecated_components branch January 30, 2023 17:31
@primer-css primer-css mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @camertron