Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guidelines regarding changesets #1781

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

jdennes
Copy link
Member

@jdennes jdennes commented Jan 25, 2023

Description

The project uses changesets rather than having contributors manually update the CHANGELOG.md file.

This branch updates the contributing guidelines to encourage people to add changesets using the provided documentation in https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md.

Integration

Does this change require any updates to code in production?

No.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@jdennes jdennes requested review from a team and camertron January 25, 2023 04:46
@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

🦋 Changeset detected

Latest commit: 335abf5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, thanks, I think we missed this when we added changesets support

@jonrohan jonrohan merged commit 716abfb into primer:main Jan 25, 2023
@primer-css primer-css mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants