Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Tracking #1769

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Release Tracking #1769

merged 2 commits into from
Jan 27, 2023

Conversation

primer-css
Copy link
Collaborator

@primer-css primer-css commented Jan 23, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/view-components@0.0.120

Patch Changes

@primer-css primer-css requested review from a team and camertron January 23, 2023 18:36
@primer-css primer-css temporarily deployed to review-pr-1769 January 23, 2023 18:36 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔗 GitHub PR

🔎 Smoke test

  • All CI checks pass
  • Docs and Lookbook open in a browser
  • Successful integration test with GitHub.com as a primary consumer of Primer View Components
    • Install the npm release candidate in npm-workspaces/primer/
    • Use bin/vendor-gem to update primer_view_components gem
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Manually test critical paths
    • Manually test release-specific bugfixes and/or features work as described

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • All new features in this release have been tested and verified as compatible with GitHub.com
  • No noticeable regressions have been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@primer-css primer-css temporarily deployed to github-pages January 23, 2023 18:40 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 23, 2023 21:30 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages January 23, 2023 21:35 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 23, 2023 23:19 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages January 23, 2023 23:23 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 24, 2023 16:40 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages January 24, 2023 16:45 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 24, 2023 18:57 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages January 24, 2023 19:02 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 25, 2023 00:09 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages January 25, 2023 00:15 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 25, 2023 15:09 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages January 25, 2023 15:14 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 25, 2023 15:38 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages January 25, 2023 15:43 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 25, 2023 18:21 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages January 25, 2023 18:25 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to review-pr-1769 January 25, 2023 19:28 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@jonrohan jonrohan added the Release pending Added to a release when it's going out soon. label Jan 27, 2023
@jonrohan jonrohan merged commit 88b1469 into main Jan 27, 2023
@jonrohan jonrohan deleted the changeset-release/main branch January 27, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release pending Added to a release when it's going out soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants