Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle switch error messages #1760

Merged
merged 14 commits into from
Jan 18, 2023
Merged

Toggle switch error messages #1760

merged 14 commits into from
Jan 18, 2023

Commits on Jan 13, 2023

  1. Add error message support to ToggleSwitches 

    Render a validation element and fill it in or hide it depending on the
response from the server.
    @neall
    neall committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    0e86389 View commit details
    Browse the repository at this point in the history

  2. In forms, top-align toggle switch with label 

    This looks a lot nicer when there is also a caption and/or validation
message after the label.
    @neall
    neall committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    60b6586 View commit details
    Browse the repository at this point in the history

  3. Reserve space for ToggleSwitch octicon 

    This will occupy the same amount of space regardless of if we are
showing one of the status octicons (loading or error) to prevent
excessive layout jumping on the page.

Also adds a gap style to the flexbox container to keep a little
distance from the label/caption/validation message.
    @neall
    neall committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    8ccf211 View commit details
    Browse the repository at this point in the history

  4. Move styles to .pcss files

    @camertron
    camertron committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    ce006f5 View commit details
    Browse the repository at this point in the history

  5. Add test for asserting errors appear on the page

    @camertron
    camertron committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    3f69035 View commit details
    Browse the repository at this point in the history

  6. Add changeset

    @camertron
    camertron committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    1b5c824 View commit details
    Browse the repository at this point in the history

  7. Generating component snapshots

    @camertron @github-actions
    camertron authored and github-actions[bot] committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    d62374b View commit details
    Browse the repository at this point in the history

  8. Disable i18n eslint rule (none of our stuff is translated)

    @camertron
    camertron committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    15fc06f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'neall/toggle-switch-error-messages' of github.com:prime… 

    …r/view_components into neall/toggle-switch-error-messages
    @camertron
    camertron committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    c005a66 View commit details
    Browse the repository at this point in the history

  10. Fix css selectors test

    @camertron
    camertron committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    3225b5d View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Fix alignment of warning icon

    @camertron
    camertron committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    39612d7 View commit details
    Browse the repository at this point in the history

  2. Update app/components/primer/alpha/toggle_switch.pcss 

    Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
    @camertron @langermank
    camertron and langermank authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c091b18 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Nudge icons down a tiny bit

    @camertron
    camertron committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    95bca4d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'neall/toggle-switch-error-messages' of github.com:prime… 

    …r/view_components into neall/toggle-switch-error-messages
    @camertron
    camertron committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    4c1d06a View commit details
    Browse the repository at this point in the history