-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle switch error messages #1760
Conversation
Render a validation element and fill it in or hide it depending on the response from the server.
This looks a lot nicer when there is also a caption and/or validation message after the label.
This will occupy the same amount of space regardless of if we are showing one of the status octicons (loading or error) to prevent excessive layout jumping on the page. Also adds a gap style to the flexbox container to keep a little distance from the label/caption/validation message.
🦋 Changeset detectedLatest commit: 4c1d06a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
…r/view_components into neall/toggle-switch-error-messages
Visual differences are expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one css request
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
…r/view_components into neall/toggle-switch-error-messages
Description
@neall and I have been pairing on getting error messages to display properly when a toggle switch request fails. This is the result.
Integration
No
Merge checklist
- [ ] Added/updated documentation