Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-Deprecate Primer::ButtonComponent #1420

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Un-Deprecate Primer::ButtonComponent #1420

merged 3 commits into from
Sep 28, 2022

Conversation

mxriverlynn
Copy link
Contributor

due to a number of issues encountered with migrating Primer::ButtonComponent to Primer::Beta::Button in dotcom, the deprecation of Primer::ButtonComponent needs to be reverted for now.

this PR reverts #1396, except for the nav.yml file for the site navigation. that file remains as-is, since it corrected the site navigation for Button

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 02037ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn temporarily deployed to github-pages September 28, 2022 20:19 Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review September 28, 2022 20:22
@mxriverlynn mxriverlynn requested review from a team and keithamus September 28, 2022 20:22
@mxriverlynn mxriverlynn enabled auto-merge (squash) September 28, 2022 20:22
@mxriverlynn mxriverlynn merged commit d662355 into main Sep 28, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/un-deprecate-button-component branch September 28, 2022 20:23
@primer-css primer-css mentioned this pull request Sep 28, 2022
Merged
jonrohan pushed a commit that referenced this pull request Sep 30, 2022
@mxriverlynn @jonrohan
Un-Deprecate Primer::ButtonComponent (#1420)
8fb09c5 
* Revert "Deprecate Primer::ButtonComponent in favor of Primer::Beta::Button (#1396)"

This reverts commit e0c50dc.

* re-fix the navigation for button

* added changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxriverlynn @jonrohan