Skip to content

Commit

Permalink
Un-Deprecate Primer::ButtonComponent (#1420)
Browse files Browse the repository at this point in the history
* Revert "Deprecate Primer::ButtonComponent in favor of Primer::Beta::Button (#1396)"

This reverts commit e0c50dc.

* re-fix the navigation for button

* added changeset
  • Loading branch information
mxriverlynn authored Sep 28, 2022
1 parent f99156f commit d662355
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/four-donuts-call.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/view-components': patch
---

un-deprecate Primer::ButtonComponent for now, due to inconsistencies and issues in migrating to Primer::Beta::Button
2 changes: 1 addition & 1 deletion app/components/primer/button_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module Primer
# Use `Button` for actions (e.g. in forms). Use links for destinations, or moving from one page to another.
class ButtonComponent < Primer::Component
status :deprecated
status :beta

DEFAULT_SCHEME = :default
LINK_SCHEME = :link
Expand Down
1 change: 0 additions & 1 deletion lib/primer/deprecations.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ module Deprecations
"Primer::Alpha::AutoComplete::Item" => "Primer::Beta::AutoComplete::Item",
"Primer::BlankslateComponent" => "Primer::Beta::Blankslate",
"Primer::BoxComponent" => "Primer::Box",
"Primer::ButtonComponent" => "Primer::Beta::Button",
"Primer::CloseButton" => "Primer::Beta::CloseButton",
"Primer::CounterComponent" => "Primer::Beta::Counter",
"Primer::DetailsComponent" => "Primer::Beta::Details",
Expand Down
2 changes: 1 addition & 1 deletion static/statuses.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"Primer::BlankslateComponent": "deprecated",
"Primer::Box": "stable",
"Primer::BoxComponent": "deprecated",
"Primer::ButtonComponent": "deprecated",
"Primer::ButtonComponent": "beta",
"Primer::ClipboardCopy": "beta",
"Primer::CloseButton": "deprecated",
"Primer::ConditionalWrapper": "alpha",
Expand Down

0 comments on commit d662355

Please sign in to comment.