recursively traverse the vnode tree until tabs are found, fixes #3625 #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
I've checked your PR. Thanks for your contribution. This example works with your TabView https://stackblitz.com/edit/angular-2yyswj?file=src%2Fmain.js%3AL14 and is broken in some cases. Nested TabView is working fine but conditional TabPanel is not working correctly. It was fixed with #1186 and to protect backward compatibility this code needs some fixes. |
tugcekucukoglu
added
the
Resolution: Needs Revision
|
Closing due to inactivity. |
tugcekucukoglu
removed
the
Resolution: Needs Revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3625
Previous:
https://codesandbox.io/p/sandbox/extending-tabview-nx8rwl?file=%252Fsrc%252Fcomponents%252FTabView.vue
Now:
https://codesandbox.io/p/sandbox/extending-tabview-forked-ipxj7h?file=%252Fsrc%252Fcomponents%252FTabView.vue