Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView: Wrapped component breaks when using v-for on TabPanel #3625

Open
Jazcash opened this issue Feb 4, 2023 · 1 comment
Open

TabView: Wrapped component breaks when using v-for on TabPanel #3625

Jazcash opened this issue Feb 4, 2023 · 1 comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working

Comments

@Jazcash
Copy link

Jazcash commented Feb 4, 2023

Describe the bug

4th example in the linked sandbox doesn't work and I can't figure out why, but feels like a possible bug.

Reproducer

https://codesandbox.io/p/sandbox/extending-tabview-nx8rwl?file=%2Fsrc%2FApp.vue

PrimeVue version

3.23.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Jazcash Jazcash added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 4, 2023
@Jazcash
Copy link
Author

Jazcash commented Feb 4, 2023

Found that the cause of this is because the computed tabs function assumes that the tab VNodes will always be the immediate slot content, which isn't always necessarily the case.

https://codesandbox.io/p/sandbox/extending-tabview-forked-ipxj7h

Jazcash added a commit to Jazcash/primevue that referenced this issue Feb 5, 2023
@Jazcash
recursively traverse the vnode tree until tabs are found, fixes prime…
5f44ee1 
…faces#3625
@Jazcash Jazcash mentioned this issue Feb 5, 2023
Closed
@bahadirsofuoglu bahadirsofuoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

recursively traverse the vnode tree until tabs are found, fixes #3625 Jazcash/primevue
2 participants
@Jazcash @bahadirsofuoglu