Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6737 Calendar month navigator #6739

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix #6737 Calendar month navigator #6739

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3903608
fix: use new Date instead of cloned date
KirilCycle Jun 7, 2024
4d4c850
fix: reset the day of the cloned date
KirilCycle Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/lib/calendar/Calendar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ export const Calendar = React.memo(
const currentViewDate = getViewDate();
let newViewDate = cloneDate(currentViewDate);
Copy link
Contributor Author

@KirilCycle KirilCycle Jun 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can i simply use new Date(), as in previous commit ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this looks good if you look down in the calendar you will see we do this...

currentDate.setDate(1); // #2948 always set to 1st of month

So clearly this spot was missed.


newViewDate.setDate(1);
newViewDate.setMonth(parseInt(value, 10));

updateViewDate(event, newViewDate);
Expand Down
Loading