Fix #6737 Calendar month navigator #6739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
KirilCycle
commented
Jun 7, 2024
| @@ -480,6 +480,7 @@ export const Calendar = React.memo( | |||
| const currentViewDate = getViewDate(); | |||
| let newViewDate = cloneDate(currentViewDate); | |||
There was a problem hiding this comment.
Can i simply use new Date(), as in previous commit ?
There was a problem hiding this comment.
No this looks good if you look down in the calendar you will see we do this...
currentDate.setDate(1); // #2948 always set to 1st of monthSo clearly this spot was missed.
KirilCycle
changed the title
melloware
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #6737 Ensure the day of the date is reset before updating the calendar. The 'navBackward' and 'navForward' methods reset the date to the first day to prevent this bug. If the line 'newViewDate.setDate(1)' is removed, the same error observed with the options will occur.