support FakeXMLHttpRequest response property #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xg-wang
reviewed
Nov 11, 2019
package.json
Outdated
| @@ -48,7 +48,7 @@ | |||
| "typescript-eslint-parser": "^21.0.2" | |||
| }, | |||
| "dependencies": { | |||
| "fake-xml-http-request": "^2.0.0", | |||
| "fake-xml-http-request": "kellyselden/FakeXMLHttpRequest#response", | |||
There was a problem hiding this comment.
It seems this package used in test is from bower.
https://github.com/pretenderjs/pretender/blob/v3.0.4/karma.conf.js#L18
There was a problem hiding this comment.
Just merged #281. Can you try rebase?
There was a problem hiding this comment.
I think it's github artifact cache didn't update. I just tried v2.1.1 and it passed tests.
kellyselden
force-pushed
the
response
branch
from
a0d00cc
to
cc501bc
Compare
|
Do you happen to see where I went wrong in the tests or code? |
|
@kellyselden It seems the changes in Line 18 in 0b04362 |
kellyselden
force-pushed
the
response
branch
from
cc501bc
to
851d639
Compare
|
@xg-wang Good call. I did that, and it appears the same issue remains. |
kellyselden
force-pushed
the
response
branch
from
851d639
to
a3cda96
Compare
|
Updated with 2.1.1 and all is good now. |
zburke
added a commit
to zburke/pretender
that referenced
this pull request
Dec 3, 2019
fake-xml-http-request v2.1.1 introduced breaking changes to the handling of the `response` property. In previous releases, `response` was not always present, allowing fake-xml-http-response to interact with libraries such as [whatwg-fetch](https://github.com/github/fetch/blob/96b37eb63ef8f2644f985cd77e7bd87b04e61ad4/fetch.js#L462) that make decisions based on that behavior. Because pretender has a caret dep on fake-xml-http-request, that change effectively broke the previous major release (v2.x) of pretender because the PR pretenderjs#280 is only available on the current major release (v3.x). This PR simply changes the dependency on fake-xml-http-request from a caret `^` to a tilde `~` in order to prevent that breaking change from leaking through. If merged to a branch split from the last v2 commit and released as v2.1.2, it would restore the previous behavior without having any effect on the current major release.
This was referenced Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re pretenderjs/FakeXMLHttpRequest#53
These 2 PRs fixed the problem for me ember-vr/ember-vr-shopping#192