Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict fake-xml-http-request to ~2.0.0 on the v2 branch #283

Closed
zburke opened this issue Dec 3, 2019 · 2 comments
Closed

restrict fake-xml-http-request to ~2.0.0 on the v2 branch #283

zburke opened this issue Dec 3, 2019 · 2 comments

Comments

@zburke
Copy link

zburke commented Dec 3, 2019

fake-xml-http-request v2.1.1 introduced breaking changes to the handling of the response property, identified in Issue 54. In previous releases, response was not always present, allowing fake-xml-http-response to interact with libraries such as whatwg-fetch that make decisions based on that behavior. Because pretender has a caret dep on fake-xml-http-request, that change effectively broke the previous major release (v2.x) of pretender because the PR addressing the change (#280) is only available for the current major release (v3.x).

An easy and low-impact solution would be to make a branch from the last commit on the v2 line and to push a new commit to that branch that changes the dependency on fake-xml-http-request from ^2.0.0 to ~2.0.0 in order to prevent the breaking change in the minor release from leaking through. Released as pretender v2.1.2, this would restore pretender's previous behavior in the v2 line without having any effect on the current major release.

@MikeTaylor
Copy link

Makes perfect sense to me.

@xg-wang
Copy link
Member

xg-wang commented Dec 12, 2019

Ugh sorry for that bad release and thanks for the suggestion!
Just pushed https://www.npmjs.com/package/pretender/v/2.1.2 and https://www.npmjs.com/package/pretender/v/3.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants