New Adapter: Readpeak #3610
Merged
New Adapter: Readpeak #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adapters/readpeak/readpeak.go
Outdated
| func getMediaType(impID string, imps []openrtb2.Imp) (openrtb_ext.BidType, error) { | ||
| for _, imp := range imps { | ||
| if imp.ID == impID { | ||
| if imp.Banner != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
There was a problem hiding this comment.
@readpeak-user PTAL at above comment and provide feedback on using Mtype
There was a problem hiding this comment.
Fixed to use mtype from bid response
Code coverage summaryNote:
readpeakRefer here for heat map coverage report |
|
tests are failing on PR with following error: run gofmt on above files to fix errors reported by test suite |
| @@ -0,0 +1,15 @@ | |||
| endpoint: https://dsp.readpeak.com/header/prebid | |||
There was a problem hiding this comment.
endpoint is reachable
curl -i --location --request POST 'https://dsp.readpeak.com/header/prebid'
HTTP/2 204
date: Fri, 05 Apr 2024 10:11:33 GMT
| - EEA | ||
| maintainer: | ||
| email: devteam@readpeak.com | ||
| gvlVendorID: 290 |
There was a problem hiding this comment.
verified gvl id
curl https://vendor-list.consensu.org/v2/vendor-list.json | jq '.vendors."290"'
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 430k 100 430k 0 0 730k 0 --:--:-- --:--:-- --:--:-- 729k
{
"id": 290,
"name": "Readpeak Oy",
"purposes": [
1,
3,
4
],
"legIntPurposes": [
2,
7,
10
],
"flexiblePurposes": [
2,
7,
10
],
"specialPurposes": [
1,
2
],
"features": [
3
],
"specialFeatures": [],
"policyUrl": "https://www.readpeak.com/terms/readpeak-privacy-policy",
"cookieMaxAgeSeconds": 7776000,
"usesCookies": true,
"cookieRefresh": true,
"usesNonCookieAccess": false,
"deviceStorageDisclosureUrl": "https://static.readpeak.com/tcf/deviceStorage.json"
}
adapters/readpeak/readpeak.go
Outdated
Comment on lines
130
to
131
| bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(request.Imp)) | ||
| bidResponse.Currency = response.Cur |
There was a problem hiding this comment.
by default line 130 will initialize bidResponse.Currency as USD
reassigning bidResponse.Currency on line 131 without checking response.Cur length may overwrite bidResponse.Currency with blank value
code block can be refactored as below
bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(request.Imp))
if len(response.Cur) != 0 {
bidResponse.Currency = response.Cur
}
Code coverage summaryNote:
readpeakRefer here for heat map coverage report |
|
@readpeak-user Pr checks are failing as you would need to run gofmt in your code files. |
Code coverage summaryNote:
readpeakRefer here for heat map coverage report |
adapters/readpeak/readpeak.go
Outdated
Comment on lines
35
to
37
| if requestCopy.Imp[i].Native == nil && requestCopy.Imp[i].Banner == nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
static/bidder-info/readpeak.yaml specifies either banner or Native is required.
prebid server core will ensure either banner or native is present else will return error before adapter code is being invoked
There was a problem hiding this comment.
Removed the check
adapters/readpeak/readpeak.go
Outdated
Comment on lines
104
to
106
| if responseData.StatusCode == http.StatusNoContent { | ||
| return nil, nil | ||
| } |
There was a problem hiding this comment.
prebid-server/adapters/response.go
Lines 26 to 28 in ec729e6
could make use of response util here
There was a problem hiding this comment.
Used util function
|
@readpeak-user test suites are failing with following error |
Code coverage summaryNote:
readpeakRefer here for heat map coverage report |
|
@onkarvhanumante I have not been able to figure out why those tests fail. Any ideas? How can I run these tests locally? |
|
When I run the tests locally with 
|
@readpeak-user requesting to merge prebid-server/adapters/pubmatic/pubmatic.go Lines 175 to 182 in 7635519 |
Code coverage summaryNote:
readpeakRefer here for heat map coverage report |
|
Thanks @onkarvhanumante. Should be fixed now. |
gargcreation1992
approved these changes
Apr 22, 2024
onkarvhanumante
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds s2s adapter for Readpeak.
First time writing Go so please check carefully :)
Link to document PR prebid/prebid.github.io#5242