New adapter readpeak (#3142) #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The logic of the bidder doesn't match the logic of the Go version, please replicate the prebid/prebid-server#3610 |
|
@przemkaczmarek Builds are failed. Please fix them |
AntoxaAntoxic
requested changes
May 23, 2024
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/test/resources/org/prebid/server/it/test-application.properties
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
May 23, 2024
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Jun 4, 2024
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Jun 7, 2024
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/readpeak/ReadPeakBidder.java
Outdated
Show resolved
Hide resolved
Comment on lines
148
to
165
| private Result<List<BidderBid>> bidsFromResponse(BidResponse bidResponse) { | ||
| final List<BidderError> errors = new ArrayList<>(); | ||
| final List<BidderBid> validBids = new ArrayList<>(); | ||
|
|
||
| for (SeatBid seatBid : bidResponse.getSeatbid()) { | ||
| if (seatBid != null) { | ||
| for (Bid bid : seatBid.getBid()) { | ||
| if (bid != null) { | ||
| try { | ||
| final BidderBid bidderBid = makeBid(bid, bidResponse); | ||
| validBids.add(bidderBid); | ||
| } catch (PreBidException e) { | ||
| errors.add(BidderError.badInput(e.getMessage())); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
please use the similar style
bidResponse.getSeatbid().stream()
.filter(Objects::nonNull)
.map(SeatBid::getBid)
.filter(Objects::nonNull)
.flatMap(Collection::stream)
.map(bid -> makeBid(bid, bidResponse.getCur(), errors))
.filter(Objects::nonNull)
.toList();
AntoxaAntoxic
requested changes
Jun 12, 2024
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/readpeak/ReadPeakBidderTest.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3142