Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lighthouse CI start regex command #470

Merged
merged 3 commits into from
Mar 27, 2021
Merged

Update Lighthouse CI start regex command #470

merged 3 commits into from
Mar 27, 2021

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Mar 27, 2021

fingers crossed 🤞

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2021

🦋 Changeset detected

Latest commit: e5c3867

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh. I meant to bring this up when we changed the server start output. I was a little iffy about dropping Listening for that reason, but I don't think anything outside of Lighthouse is relying on it.

@marvinhagemeister
Copy link
Member Author

marvinhagemeister commented Mar 27, 2021

mh, according to their docs that should be it, but it looks like there is more going on. Lighthouse can't find that message for some reason.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2021

Size Change: +79 B (0%)

Total Size: 693 kB

Filename Size Change
packages/wmr/wmr.cjs 660 kB +79 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/demo/dist/about/index.html 657 B 0 B
examples/demo/dist/assets/Calendar.********.css 702 B 0 B
examples/demo/dist/assets/style.********.css 386 B 0 B
examples/demo/dist/chunks/class-fields.********.js 201 B 0 B
examples/demo/dist/chunks/compat.********.js 15.3 kB 0 B
examples/demo/dist/chunks/index.********.js 200 B 0 B
examples/demo/dist/chunks/prerender.********.js 2.44 kB 0 B
examples/demo/dist/class-fields/index.html 635 B 0 B
examples/demo/dist/compat/index.html 1.49 kB 0 B
examples/demo/dist/env/index.html 712 B 0 B
examples/demo/dist/error/index.html 646 B 0 B
examples/demo/dist/files/index.html 675 B 0 B
examples/demo/dist/index.********.js 7.19 kB 0 B
examples/demo/dist/index.html 703 B 0 B
examples/demo/dist/lazy-and-late/index.html 658 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister marked this pull request as ready for review March 27, 2021 15:54
@marvinhagemeister marvinhagemeister merged commit de83c08 into main Mar 27, 2021
@marvinhagemeister marvinhagemeister deleted the fix-lhci branch March 27, 2021 15:55
@github-actions github-actions bot mentioned this pull request Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants