Fix infinite loop when port is not available

preactjs · Mar 27, 2021 · 07dbd20 · 07dbd20
1 parent 97e51f0
commit 07dbd20
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/five-hornets-admire.md b/.changeset/five-hornets-admire.md
@@ -0,0 +1,5 @@
+---
+'wmr': patch
+---
+
+Fix potential infinite loop when searching for a free port
diff --git a/packages/wmr/src/lib/net-utils.js b/packages/wmr/src/lib/net-utils.js
@@ -37,10 +37,10 @@ export async function getFreePort(port) {
 
 	// Limit to 20 attempts for now
 	while (!found && attempts <= 20) {
-		if (!isPortFree(port)) {
-			port++;
-			attempts++;
-		}
+		if (isPortFree(port)) break;
+
+		port++;
+		attempts++;
 	}
 
 	return port;