Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report percentages from original size #44

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Report percentages from original size #44

merged 2 commits into from
Dec 18, 2020

Conversation

arendjr
Copy link

@arendjr arendjr commented Oct 23, 2020

Fixes #31.

bartlomiejzuber
bartlomiejzuber reviewed Dec 9, 2020
View reviewed changes
src/utils.js Outdated Show resolved Hide resolved
developit
developit approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor suggestions I'd like to apply if that's alright with you.

src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
@arendjr
Copy link
Author

arendjr commented Dec 18, 2020

Cool 👍

@developit developit merged commit e37da25 into preactjs:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomiejzuber bartlomiejzuber bartlomiejzuber left review comments

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

% change value is incorrect
3 participants
@arendjr @developit @bartlomiejzuber