Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

% change value is incorrect #31

Closed
necolas opened this issue Aug 6, 2020 · 0 comments · Fixed by #44
Closed

% change value is incorrect #31

necolas opened this issue Aug 6, 2020 · 0 comments · Fixed by #44

Comments

@necolas
Copy link

necolas commented Aug 6, 2020

If you have a 1KB file, reduced by 0.5KB, it reports the change as 100% rather than 50%.

This line needs to use the original size as the divisor, so delta + size rather than size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report percentages from original size arendjr/compressed-size-action
1 participant
@necolas