Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll now playing overlay text when overflowing #28017

Merged
merged 7 commits into from
May 3, 2024

Use `IsLoaded` instead of `Schedule`

c21b7c7
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Scroll now playing overlay text when overflowing #28017

Use `IsLoaded` instead of `Schedule`
c21b7c7
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, SingleThread) failed May 3, 2024 in 1s

5771 passed, 2 failed and 52 skipped

Tests failed

❌ TestResults-Windows-SingleThread.trx

5825 tests were completed in 1554s with 5771 passed, 2 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback 1✅ 1❌ 1s
osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation 44✅ 1❌ 65s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback

❌ TestAllSamplesStopDuringSeek
	sample playback disabled
✅ TestConstructor

❌ osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation

❌ TestAttemptPlayBeatmapMissingFails
	System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-82030f15-f251-466a-bb3c-41d7b0ec6114\files\a\a3\a3cdca78c8435a097b6116f17796e4c8415e302475e30ecf73da307553c43645' because it is being used by another process.
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapOptionsInput
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConstructor
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestExitGameFromSongSelect
✅ TestExitImmediatelyAfterCompletion
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithEscape
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithEscape
✅ TestExitWithHoldDisabled
✅ TestExitWithOperationInProgress
✅ TestFeaturedArtistDisclaimerDialog
✅ TestForceExitWithOperationInProgress
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMenuMakesMusic
✅ TestModSelectInput
✅ TestModsResetOnEnteringMultiplayer
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenOptionsAndExitWithEscape
✅ TestOverlayClosing
✅ TestPresentBeatmapAfterDeletion
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestRetryCountIncrements
✅ TestRetryFromResults
✅ TestRetryImmediatelyAfterCompletion
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestShowMedalAtResults
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongSelectBackActionHandling
✅ TestSongSelectScrollHandling
✅ TestToolbarHiddenByUser
✅ TestTouchScreenDetectionAtSongSelect
✅ TestTouchScreenDetectionInGame
✅ TestWaitForNextTrackInMenu

Annotations

Check failure on line 0 in TestResults-Windows-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback ► TestAllSamplesStopDuringSeek

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  sample playback disabled
Raw output
sample playback disabled
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)

Check failure on line 275 in osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation ► TestAttemptPlayBeatmapMissingFails

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-82030f15-f251-466a-bb3c-41d7b0ec6114\files\a\a3\a3cdca78c8435a097b6116f17796e4c8415e302475e30ecf73da307553c43645' because it is being used by another process.
Raw output
System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-82030f15-f251-466a-bb3c-41d7b0ec6114\files\a\a3\a3cdca78c8435a097b6116f17796e4c8415e302475e30ecf73da307553c43645' because it is being used by another process.
   at System.IO.FileSystem.DeleteFile(String fullPath)
   at osu.Framework.Platform.NativeStorage.Delete(String path)
   at osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation.<>c__DisplayClass11_0.<TestAttemptPlayBeatmapMissingFails>b__4() in D:\a\osu\osu\osu.Game.Tests\Visual\Navigation\TestSceneScreenNavigation.cs:line 275
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)