Scroll now playing overlay text when overflowing #28017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Apr 29, 2024
|
Lol, just a simple marquee like what you have. Definitely not like the newer Winamp. |
bdach
approved these changes
May 3, 2024
peppy
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done locally for now as I'm not sure where else this will be used. Also less effort on the abstraction of delay, text speed, margin, and parent width.
Made it work for all 3 x anchors just so I didn't have to write a comment saying it only works for centre and possibly reused in the future.Takes inspiration of Winamp (Classic skin) and Apple Music:
Unsure what Winamp skin @arflyte was referring to. Modern and Bento / Big Bento has this right and left scroll loop:
Which I think looks wrong (because at least in English, text is read left to right). For very long text scrolling back, I wouldn't comprehend what it says.