Fix incorrect maximum accuracy display with recent slider end changes

osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs

@@ -259,6 +259,30 @@ public void TestLegacyComboIncrease()
         }
 #pragma warning restore CS0618
 
+        [Test]
+        public void TestMaxAccuracyOnIgnoreMiss()
+        {
+            beatmap = new TestBeatmap(new RulesetInfo())
+            {
+                HitObjects = new List<HitObject>
+                {
+                    new TestHitObject(HitResult.Great),
+                    new TestHitObject(HitResult.LargeTickHit, HitResult.IgnoreMiss),
+                }
+            };
+
+            scoreProcessor = new TestScoreProcessor();
+            scoreProcessor.ApplyBeatmap(beatmap);
+
+            scoreProcessor.ApplyResult(new JudgementResult(beatmap.HitObjects[0], beatmap.HitObjects[0].CreateJudgement()) { Type = HitResult.Miss });
+            Assert.That(scoreProcessor.Combo.Value, Is.EqualTo(0));
+            Assert.That(scoreProcessor.Accuracy.Value, Is.EqualTo(0));
+
+            scoreProcessor.ApplyResult(new JudgementResult(beatmap.HitObjects[1], beatmap.HitObjects[1].CreateJudgement()) { Type = HitResult.IgnoreMiss });
+            Assert.That(scoreProcessor.Accuracy.Value, Is.EqualTo(0));
+            Assert.That(scoreProcessor.MaximumAccuracy.Value, Is.EqualTo(0));
+        }
+
         [Test]
         public void TestComboBreak()
         {

osu.Game/Rulesets/Scoring/ScoreProcessor.cs

@@ -202,6 +202,8 @@ public override void ApplyBeatmap(IBeatmap beatmap)
 
         protected sealed override void ApplyResultInternal(JudgementResult result)
         {
+            HitResult maxResult = result.Judgement.MaxResult;
+
             result.ComboAtJudgement = Combo.Value;
             result.HighestComboAtJudgement = HighestCombo.Value;
 
@@ -210,29 +212,29 @@ protected sealed override void ApplyResultInternal(JudgementResult result)
 
             scoreResultCounts[result.Type] = scoreResultCounts.GetValueOrDefault(result.Type) + 1;
 
-            if (!result.Type.IsScorable())
-                return;
-
-            if (result.Type.IncreasesCombo())
-                Combo.Value++;
-            else if (result.Type.BreaksCombo())
-                Combo.Value = 0;
-
-            result.ComboAfterJudgement = Combo.Value;
-
-            if (result.Type.AffectsAccuracy())
+            if (maxResult.AffectsAccuracy())
             {
-                currentMaximumBaseScore += Judgement.ToNumericResult(result.Judgement.MaxResult);
+                currentMaximumBaseScore += Judgement.ToNumericResult(maxResult);
                 currentBaseScore += Judgement.ToNumericResult(result.Type);
                 currentAccuracyJudgementCount++;
             }
 
-            if (result.Type.IsBonus())
-                currentBonusPortion += GetBonusScoreChange(result);
-            else
-                currentComboPortion += GetComboScoreChange(result);
+            if (!result.Type.IsScorable())
+            {
+                if (result.Type.IncreasesCombo())
+                    Combo.Value++;
+                else if (result.Type.BreaksCombo())
+                    Combo.Value = 0;
 
-            ApplyScoreChange(result);
+                result.ComboAfterJudgement = Combo.Value;
+
+                if (result.Type.IsBonus())
+                    currentBonusPortion += GetBonusScoreChange(result);
+                else
+                    currentComboPortion += GetComboScoreChange(result);
+
+                ApplyScoreChange(result);
+            }
 
             if (!IsSimulating)
             {

osu.Game/Screens/Play/HUD/GameplayAccuracyCounter.cs

@@ -23,11 +23,11 @@ protected override void LoadComplete()
         {
             base.LoadComplete();
 
-            AccuracyDisplay.BindValueChanged(mod =>
+            AccuracyDisplay.BindValueChanged(mode =>
             {
                 Current.UnbindBindings();
 
-                switch (mod.NewValue)
+                switch (mode.NewValue)
                 {
                     case AccuracyDisplayMode.Standard:
                         Current.BindTo(scoreProcessor.Accuracy);