Fix incorrect maximum accuracy display with recent slider end changes #25492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
requested changes
Nov 17, 2023
| currentBonusPortion += GetBonusScoreChange(result); | ||
| else | ||
| currentComboPortion += GetComboScoreChange(result); | ||
| if (!result.Type.IsScorable()) |
There was a problem hiding this comment.
Is this condition reversed, or am I misunderstanding this?
There was a problem hiding this comment.
Yeah I'm a bit confused how this happened. It should be inverse (I likely broke this in refactoring after actually testing this PR).
|
Also need to update |
|
FWIW this PR is probably defunct based on forward direction with slider mechanics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25428. Regressed with #25342.
While this does fix the issue, I'm not confident in this one as a forward direction.
ScoreProcessor.ApplyResultInternallyannoys me.IsScoreableseems like a really weird check. We already have so many other related checks that this one feels like it shouldn't need to exist..